From: Eli Zaretskii <eliz@gnu.org>
To: Mekeor Melire <mekeor@posteo.de>
Cc: 68970@debbugs.gnu.org
Subject: bug#68970: [PATCH] In Info-url-alist, add .html extension to %e format-sequence
Date: Sat, 10 Feb 2024 15:56:04 +0200 [thread overview]
Message-ID: <86r0hktocr.fsf@gnu.org> (raw)
In-Reply-To: <87cyt4316d.fsf@posteo.de> (message from Mekeor Melire on Sat, 10 Feb 2024 13:16:21 +0000)
> From: Mekeor Melire <mekeor@posteo.de>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 10 Feb 2024 13:16:21 +0000
>
> 2024-02-10 09:46 eliz@gnu.org:
>
> > > From: Mekeor Melire <mekeor@posteo.de>
> > > Cc: Eli Zaretskii <eliz@gnu.org>
> > > Date: Fri, 09 Feb 2024 22:00:47 +0000
> > >
> > > Note that in the mean time, the fill-column has been changed for the
> > > Emacs repository via directory-local variables. For this patch, I
> > > did not use the "new" fill-column value so that the changes to the
> > > docstring can be seen well in the diff. Please let me know if you'd
> > > like the docstrings to be refilled according to the new fill-column.
> >
> > From where I stand, the fill-column for commit log messages is just a
> > guideline, not a hard requirement. It is more important to have the
> > doc strings filled so they are easily readable. The hard requirements
> > are spelled out in CONTRIBUTE.
>
> Sorry, I was referring to emacs-lisp-docstring-fill-column which Stefan
> Kangas increased from 65 to 72 on 2nd February 2024. Should I refill the
> docstring of Info-url-alist to match the new value?
I understood, and answered your question above. To clarify: if the
doc string looks okay to you, there's no need to refill.
> > Two spaces between sentences, please.
>
> Sorry, I will fix it.
>
> > Should we add here tests for the Top node?
>
> Yes, that's a good idea. I will do so.
Thanks.
next prev parent reply other threads:[~2024-02-10 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 13:27 bug#68970: 30.0.50; Info.el: Info-url-alist should support format-sequence that encodes "Top" node as "index" Mekeor Melire
2024-02-07 14:51 ` Eli Zaretskii
2024-02-07 19:52 ` Mekeor Melire
2024-02-07 20:18 ` Eli Zaretskii
2024-02-07 22:10 ` Mekeor Melire
2024-02-08 6:26 ` Eli Zaretskii
2024-02-08 20:20 ` Mekeor Melire
2024-02-09 7:02 ` Eli Zaretskii
2024-02-09 22:00 ` bug#68970: [PATCH] In Info-url-alist, add .html extension to %e format-sequence Mekeor Melire
2024-02-10 7:46 ` Eli Zaretskii
2024-02-10 13:16 ` Mekeor Melire
2024-02-10 13:56 ` Eli Zaretskii [this message]
2024-02-10 22:41 ` bug#68970: [PATCH v2] " Mekeor Melire
2024-02-11 7:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0hktocr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68970@debbugs.gnu.org \
--cc=mekeor@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.