From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Missing snprintf in ucrt mingw + vc-refresh in find-file hook? Date: Wed, 14 Feb 2024 16:30:54 +0200 Message-ID: <86r0hfxgm9.fsf@gnu.org> References: <6aed5106-b78c-49f1-8caa-a7f9d34c161b@gutov.dev> <207528e2-6bec-436e-8868-8e7b707133f6@gutov.dev> <86sf1wpjui.fsf@gnu.org> <8876d606-c4af-4a27-a1b1-4c3dea6d720e@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38277"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arthur.miller@live.com, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 14 15:31:48 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1raGIe-0009sI-Lk for ged-emacs-devel@m.gmane-mx.org; Wed, 14 Feb 2024 15:31:48 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1raGHx-0000G5-CO; Wed, 14 Feb 2024 09:31:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raGHt-0000Fd-Kl for emacs-devel@gnu.org; Wed, 14 Feb 2024 09:31:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raGHs-0005WP-HC; Wed, 14 Feb 2024 09:31:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zCAqxdgtf0ocXYPp64Uko5Q1w5A0w3Mar2MLQUHRZcw=; b=nPxJ1HhEERe7 VNiOf80oEW2kQun7FU03ngX8hYBm8WK9EF4qSZSog06MNasotyrfWXm+dHTlFJHR3svD8Dx/pWP9+ 2YEMUf86YCyxeduMTtppNMzWvhDn60UnRiceZCeAShdDx4Bz/SfODbQFDrMUf7nfBOM4xNG4Ro6ud jWn3D9cLjgJRK9lBPSz6usFnlUYCNRevXEPvkhVcNCd8fw7wp3mKq76mo5ecVDOWFbpHI4BjdnCxA brS93WvmtO5CFV+MrU7UP+TQk2c6UqQrSAbA5I+d60XGD6Tb1h0Szql8hpJVx/yhWLr03ov8jy3YX 8p7HMVpKw60bKpd7olJcPA==; In-Reply-To: <8876d606-c4af-4a27-a1b1-4c3dea6d720e@gutov.dev> (message from Dmitry Gutov on Tue, 13 Feb 2024 23:26:42 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316202 Archived-At: > Date: Tue, 13 Feb 2024 23:26:42 +0200 > Cc: emacs-devel@gnu.org > From: Dmitry Gutov > > On 13/02/2024 15:36, Eli Zaretskii wrote: > > > > I understand your POV, but this is turned on by default in Emacs long > > ago. So the default cannot be changed just because you personally > > dislike it. Instead, I suggest that you change the default value of > > mode-line format locally. Or remove vc-refresh-state from > > find-file-hook. Or try playing with the value of vc-display-status. > > Or some other change that could do what you want; look in vc-hooks.el > > for ideas. > > We could try dropping the forced refresh from find-file-hook. Then we'd > have a function there that should be called differently, which would > just reset the saved backend/status for the file, and the cached value > for vc-mode (the mode-line element). > > Then, if the user disabled showing the VC state in the mode-line, and > doesn't have any other packages installed that use the status, Git won't > be called, at least not right away. What is the purpose of such a change? Does it target users who don't want vc-refresh-state in find-file-hook, but still want the VC info shown on the mode line? That sounds like a strange preference, since find-file-hook is called just once per file buffer, whereas showing the info on the mode line can potentially cause vc-refresh-state (or something similar) to be called much more frequently, right? So before we discuss such a move, even as an experiment, I'd like to understand better what would be the intended effect in user-facing terms, and make sure we indeed consider such a behavior change reasonable. Because this kind of changes is likely to cause unintended problems, so I'd like to be sure we really want it before we start investing time and efforts in it. Likewise, I would like to avoid the situation where Arthur (or someone else) spends time and efforts in experimenting with such a setup, only to be told later that we don't think the results makes sense to us.