From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected Date: Thu, 29 Feb 2024 19:56:31 +0200 Organization: LINKOV.NET Message-ID: <86r0gvi27k.fsf@mail.linkov.net> References: <86y1c6688u.fsf@mail.linkov.net> <86plxiq6hv.fsf@mail.linkov.net> <867cjejfan.fsf@mail.linkov.net> <871q9k6vfo.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22281"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 68801@debbugs.gnu.org, sbaugh@catern.com To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 29 18:57:48 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfkfD-0005bQ-9q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Feb 2024 18:57:47 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfkf1-0007iz-Go; Thu, 29 Feb 2024 12:57:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfkf0-0007io-WD for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 12:57:35 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfkf0-0006TO-Ns for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 12:57:34 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rfkfS-0003Rq-08 for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 12:58:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Feb 2024 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68801 X-GNU-PR-Package: emacs Original-Received: via spool by 68801-submit@debbugs.gnu.org id=B68801.170922947913246 (code B ref 68801); Thu, 29 Feb 2024 17:58:01 +0000 Original-Received: (at 68801) by debbugs.gnu.org; 29 Feb 2024 17:57:59 +0000 Original-Received: from localhost ([127.0.0.1]:35314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfkfP-0003Ra-4g for submit@debbugs.gnu.org; Thu, 29 Feb 2024 12:57:59 -0500 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfkfN-0003RM-6V for 68801@debbugs.gnu.org; Thu, 29 Feb 2024 12:57:57 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 403E91C0008; Thu, 29 Feb 2024 17:57:01 +0000 (UTC) In-Reply-To: (Spencer Baugh's message of "Tue, 27 Feb 2024 15:45:23 -0500") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280800 Archived-At: > Spencer Baugh writes: >> I'm thinking the right thing to do is just to go with my original patch >> which only binds RET when there's a selected completion. That's simple >> and straightforward. >> >> But I'm not sure how to adapt my completion-show-help change for that: I >> want to hint to the user that they should hit RET, but RET is only bound >> when a completion is selected, which isn't the case when *Completions* >> is first displayed. Any ideas? Could we just hardcode "RET" in the >> help text? > > The solution is obvious in retrospect, just add a defvar to force the > bindings on. > > Complete patch attached, I think this closes the bug. Good idea, thanks. I will test your patch for a while.