From: Juri Linkov <juri@linkov.net>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 68801@debbugs.gnu.org, sbaugh@catern.com
Subject: bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected
Date: Thu, 29 Feb 2024 19:56:31 +0200 [thread overview]
Message-ID: <86r0gvi27k.fsf@mail.linkov.net> (raw)
In-Reply-To: <iermsrly6u4.fsf@janestreet.com> (Spencer Baugh's message of "Tue, 27 Feb 2024 15:45:23 -0500")
> Spencer Baugh <sbaugh@janestreet.com> writes:
>> I'm thinking the right thing to do is just to go with my original patch
>> which only binds RET when there's a selected completion. That's simple
>> and straightforward.
>>
>> But I'm not sure how to adapt my completion-show-help change for that: I
>> want to hint to the user that they should hit RET, but RET is only bound
>> when a completion is selected, which isn't the case when *Completions*
>> is first displayed. Any ideas? Could we just hardcode "RET" in the
>> help text?
>
> The solution is obvious in retrospect, just add a defvar to force the
> bindings on.
>
> Complete patch attached, I think this closes the bug.
Good idea, thanks. I will test your patch for a while.
next prev parent reply other threads:[~2024-02-29 17:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 18:49 bug#68801: 30.0.50; minibuffer-visible-completions=t makes RET in completion-in-region a no-op with nothing selected Spencer Baugh
2024-01-30 17:28 ` Juri Linkov
2024-01-30 20:21 ` Spencer Baugh
2024-01-31 7:58 ` Juri Linkov
2024-02-09 7:17 ` Juri Linkov
2024-02-10 18:14 ` sbaugh
2024-02-11 17:59 ` Juri Linkov
2024-02-11 21:02 ` sbaugh
2024-02-16 14:34 ` Spencer Baugh
2024-02-18 7:46 ` Juri Linkov
2024-02-26 16:04 ` Spencer Baugh
2024-02-27 20:45 ` Spencer Baugh
2024-02-29 17:56 ` Juri Linkov [this message]
2024-03-15 7:41 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0gvi27k.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=68801@debbugs.gnu.org \
--cc=sbaugh@catern.com \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.