From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70322: 30.0.50; format-seconds with %z doesn't handle zero input correctly Date: Wed, 10 Apr 2024 17:01:56 +0300 Message-ID: <86r0fduxij.fsf@gnu.org> References: <87v84pa67l.fsf@gmail.com> <861q7dwhs2.fsf@gnu.org> <87bk6h8jyi.fsf@gmail.com> <86zfu1v0cx.fsf@gnu.org> <871q7djqtk.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31467"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70322-done@debbugs.gnu.org, geza.herman@gmail.com To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 10 16:03:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruYXx-0007rp-AA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Apr 2024 16:03:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ruYXT-0007Q1-Vf; Wed, 10 Apr 2024 10:02:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruYXQ-0007PE-Fh for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 10:02:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ruYXQ-0006AP-6W for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 10:02:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ruYXY-0004le-Jk for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 10:03:04 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Apr 2024 14:03:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 70322 X-GNU-PR-Package: emacs Mail-Followup-To: 70322@debbugs.gnu.org, eliz@gnu.org, Herman, geza.herman@gmail.com Original-Received: via spool by 70322-done@debbugs.gnu.org id=D70322.171275774117850 (code D ref 70322); Wed, 10 Apr 2024 14:03:03 +0000 Original-Received: (at 70322-done) by debbugs.gnu.org; 10 Apr 2024 14:02:21 +0000 Original-Received: from localhost ([127.0.0.1]:54108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruYWq-0004dq-Of for submit@debbugs.gnu.org; Wed, 10 Apr 2024 10:02:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33786) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruYWj-0004cV-G4 for 70322-done@debbugs.gnu.org; Wed, 10 Apr 2024 10:02:17 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruYWV-00060s-58; Wed, 10 Apr 2024 10:01:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=+hpNLLXBqhA7ROwVqIvtOOyOjI2Wy/v3XTZ+Z/PBzZw=; b=rYzC9JQ5isTrwXT7v1aN +rr+0rzSnbRWd8P33E8dnrOo/eCfgpZomt5aoaPVhuWhZDi/fUhB6oO3he47Fq9lvozLaMA3unwCs z7IVYjKlMIQSSJztVenjZZJo+ZbVWwn8iqCvq1jtoX8+G+FiGDkhHGEcaxOyNHYk+ydppmkdh33wP 4W0vA3lYo2X4/A8iBDloawMp5rnNMsAEwlRyY6vyDwjVMydSTo7d78u3UKI1dhXPW2N+I6CIQq/73 B2obMiOTx/XJGFQh8kbEHRL10/u5FT5qPx4AVndDuxqjgPefxfKzwtHEE/aB7y0sD+A+uBP20gaJ0 Cw6MWuO2rk9Tyw==; In-Reply-To: <871q7djqtk.fsf@gmx.net> (message from Stephen Berman on Wed, 10 Apr 2024 15:21:59 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283050 Archived-At: > From: Stephen Berman > Cc: Géza Herman , > 70322@debbugs.gnu.org > Date: Wed, 10 Apr 2024 15:21:59 +0200 > > On Wed, 10 Apr 2024 16:00:30 +0300 Eli Zaretskii wrote: > > >> From: Herman, Géza > >> Cc: Herman Géza , > >> 70322@debbugs.gnu.org > >> Date: Wed, 10 Apr 2024 14:44:52 +0200 > >> > >> > >> Eli Zaretskii writes: > >> > >> > Does the patch below give good results? > >> > >> Yes, both yours and Stephen's patch fix the problem > > > > Thanks. > > > > Stephen, any argumentation for which one is better? > > AFAICT both give the same results, but since yours specifically targets > the case where %z is used, which directly addresses the bug report, it > is conceptually the better fix. Thanks, so I've now installed my change, and I'm closing this bug.