From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70589: [PATCH] Refine the Custom type of generated '*-modes' options Date: Fri, 26 Apr 2024 20:15:32 +0300 Message-ID: <86r0esxcy3.fsf@gnu.org> References: <86frv8z8zc.fsf@gnu.org> <865xw4z7bn.fsf@gnu.org> <86zftgxj75.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5369"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70589@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 26 19:17:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0PCM-00018x-Sz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Apr 2024 19:17:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0PBy-0001Jz-Tx; Fri, 26 Apr 2024 13:17:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0PBw-0001Jc-0F for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 13:16:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0PBu-0001rl-Hj for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 13:16:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0PCC-0006h6-9U for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 13:17:12 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2024 17:17:11 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70589 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70589-submit@debbugs.gnu.org id=B70589.171415176924963 (code B ref 70589); Fri, 26 Apr 2024 17:17:11 +0000 Original-Received: (at 70589) by debbugs.gnu.org; 26 Apr 2024 17:16:09 +0000 Original-Received: from localhost ([127.0.0.1]:38380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0PB5-0006Tl-Pp for submit@debbugs.gnu.org; Fri, 26 Apr 2024 13:16:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0PB1-0006Rv-9e for 70589@debbugs.gnu.org; Fri, 26 Apr 2024 13:16:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0PAc-0001kn-KF; Fri, 26 Apr 2024 13:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BIJ5Bv0r5ZEvb68MM/S7FwNhKPzwyXG1d9h+KV6MBPI=; b=pjcdqwxTDkRn mTjMqIawg8Xx+NkXzPleUGJzbZI/G39Q+H1UPFrX3UlKYpBZZwUvNZvahbnbmqagBKgfup6jfGgr2 Fnkio175S6q2KjeAxk9jvcGak83EKCSmRZVk1SoFnwGn71xM6eKLoySKnG8tRaWvVOBWx9DR63bkj W+5cKeTw2ynNoXw4WnBfAIns2EmWx6LNnahqykfbkkaYwf2CFYJ9I6hmoiNEAAIF5WCJQkQePeVfN FXs9a9Bi5udjQ2wLT+e/bhkv25/f5h1TNrnhDM4kRyZmXYMPYWuCd4Opdv22bjlTHIYkP+9evDr2M vk+RUTH0TuhRRW1CbxW7rw==; In-Reply-To: (message from Eshel Yaron on Fri, 26 Apr 2024 18:34:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284001 Archived-At: > From: Eshel Yaron > Cc: 70589@debbugs.gnu.org, monnier@iro.umontreal.ca > Date: Fri, 26 Apr 2024 18:34:20 +0200 > > Eli Zaretskii writes: > > >> From: Eshel Yaron > >> Cc: 70589@debbugs.gnu.org, monnier@iro.umontreal.ca > >> Date: Fri, 26 Apr 2024 14:24:42 +0200 > >> > >> >> These are slightly different: a value of t ("Enable in all major modes") > >> >> says to enable everywhere, while a t inside a list ("All major modes") > >> >> says to enable in modes that were not mentioned earlier in the list (so > >> >> putting t in the end of the list means "otherwise, enable"). Similarly > >> >> for the "none" alternatives: a value of nil ("Don't enable...") means we > >> >> never enable the minor mode, while the effect of a nil inside the list > >> >> is relative to the previous elements, and means "otherwise, don't". > >> >> Does that make sense? > >> > > >> > It might make sense, if we change the labels to say what you tell > >> > above. > >> > > >> > Thanks. > >> > >> OK, here's an updated patch with revised labels: > > > > Thanks, but I find the likes of "By default, enable" not clear enough. > > Would it be accurate to say this instead: > > > > (const :tag "Enable in any other mode" t) > > (const :tag "Don't enable in the other modes" nil) > > That could also work, but I think this wording is a bit confusing when > entering the first list element (so there are no "other mode/s" yet). > If you think it's nevertheless preferable, I don't object. Feel free to suggest a better wording, that caters also to that special situation.