From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70576: [PATCH] `repeat-echo-message-string': support repeat keymap "hints" Date: Thu, 02 May 2024 10:16:47 +0300 Message-ID: <86r0ekn0o0.fsf@gnu.org> References: <45C35B69-6DA8-4212-BD87-50B2A3959A86@gmail.com> <86h6fo3e7e.fsf@mail.linkov.net> <86cyqaezhc.fsf@mail.linkov.net> <86ttjle92p.fsf@mail.linkov.net> <86zft8676h.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1485"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70576@debbugs.gnu.org, jdtsmith@gmail.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 02 09:17:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2QhS-00008T-0T for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 May 2024 09:17:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2QhM-0006M1-0P; Thu, 02 May 2024 03:17:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2QhJ-0006Lh-7D for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 03:17:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2QhI-0003rI-VA for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 03:17:40 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2Qhe-0001vS-IL for bug-gnu-emacs@gnu.org; Thu, 02 May 2024 03:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 May 2024 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70576 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70576-submit@debbugs.gnu.org id=B70576.17146342417395 (code B ref 70576); Thu, 02 May 2024 07:18:02 +0000 Original-Received: (at 70576) by debbugs.gnu.org; 2 May 2024 07:17:21 +0000 Original-Received: from localhost ([127.0.0.1]:42033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Qgy-0001vD-NO for submit@debbugs.gnu.org; Thu, 02 May 2024 03:17:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2Qgx-0001v7-Fc for 70576@debbugs.gnu.org; Thu, 02 May 2024 03:17:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2QgV-0003n4-FV; Thu, 02 May 2024 03:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=u14/Dpnd3IOjArW40WtYhvmL4kosZY7jmh/zHqHnB5o=; b=pVF19R2Qh1Fi BCZuxc8oszRfQz8e5vMD3Js3tpWG5DHakWvhqp0/v3jUnCyIOK8CmSMpgU6qR1d5OIJgjFyPwnCbs 3PIiX+E3qY8GZ2JKvsnH9QUJcZYEwc6TkwTcE5KhMbHv6L9Rke1ZlKJaJGWkeu0tu9dDY5SHWYSi6 NBufeGGwMAMYohZ6bs7so75mEi19kGv5ZT9SCBnvIQTKygE9mCsaamHYwppKHv99Kn6nOorhqDHxR SOVHs/E3RWUD8Ch/qUEZFURMFlJ24CAk3vZHCgGC/5IZt9dw7khdG3FGjs+N4sAgAoUByYqx1/v85 2l/W90ilBBufDhDaXlbOdA==; In-Reply-To: <86zft8676h.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 02 May 2024 09:48:06 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284279 Archived-At: > Cc: 70576@debbugs.gnu.org > From: Juri Linkov > Date: Thu, 02 May 2024 09:48:06 +0300 > > close 70576 30.0.50 > thanks > > >>> (defvar-keymap expreg-repeat-map > >>> :doc "Repeat map for `expreg' actions." > >>> :repeat '(:hints ((expreg-expand . "expand") (expreg-contract . "contract"))) > >>> "\\" 'expreg-expand > >>> "|" 'expreg-contract) > >> > >> If a hint is missing for a command, it should just have its key mentioned. > >> It looks like your idea would require changes to defvar-keymap. Do you > >> want to propose a patch? We'd need some way to pass the hints in; perhaps > >> the macro could set a property on the command symbol as you initially > >> proposed. > > > > Alright, let's add this to defvar-keymap. Please try the following patch. > > Thanks for the feature request. This is pushed now. Thanks, but please also update the ELisp manual and add an entry to NEWS about this change.