From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master 6d4179957a8: Fix test of whether to insert lexical-binding cookies in custom files
Date: Sat, 11 May 2024 19:36:22 +0300 [thread overview]
Message-ID: <86r0e81f21.fsf@gnu.org> (raw)
> + ;; The previous test `eobp' was written with an appalling
> + ;; lack of forethought or testing, being easily misled if
> + ;; the user should have left point at eob in a buffer
> + ;; visiting the custom file.
> + (when (eq (point-min) (point-max))
Is this test robust enough? Why not use buffer-size instead?
next reply other threads:[~2024-05-11 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 16:36 Eli Zaretskii [this message]
2024-05-11 16:55 ` master 6d4179957a8: Fix test of whether to insert lexical-binding cookies in custom files Andreas Schwab
2024-05-11 16:58 ` Andreas Schwab
2024-05-11 17:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0e81f21.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.