From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Stipples support in MS-Windows port Date: Mon, 20 May 2024 14:15:36 +0300 Message-ID: <86r0dwag4n.fsf@gnu.org> References: <87a5l49a53.fsf@yahoo.com> <87seyw7udp.fsf@yahoo.com> <87wmo0zzni.fsf@yahoo.com> <86r0e83gez.fsf@gnu.org> <861q661vgf.fsf@gmail.com> <86le4dvxx9.fsf@gmail.com> <87frulynby.fsf@yahoo.com> <86zfslctt8.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40929"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, emacs-devel@gnu.org To: "Elijah G." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 20 13:16:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s910R-000AO7-Ic for ged-emacs-devel@m.gmane-mx.org; Mon, 20 May 2024 13:16:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s90zp-0008W0-HQ; Mon, 20 May 2024 07:16:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s90zd-0008Tb-9A for emacs-devel@gnu.org; Mon, 20 May 2024 07:15:49 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s90zc-0000ts-FR; Mon, 20 May 2024 07:15:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jrDDs9cc0udQjTFdhcFNHY09jwk5Ot48YF8q7Fp4nlw=; b=BMIbjs2oHeED h0xiXO1qxr0+0Ow/hz5ZseanXIlHeAy7xnxaM2+fmk3Q4pcgqa2Gqcen3+aSlbu/MGO5kisjVeZS9 8Z7gnmoDAa1/zIYBeaEVvdM3lquZ3RKGESTvO4E+obIZL/L7IeahmgAYzRTqvFFg0Qhg8i5X/O34T APsf/s8L2NdnYJ9o3hoaeiGL+D94+BUlLRiSYVnDsllTWMRNKEorD0uUCXk/XcttKa9c7ASnjUsCO TYfNR7AwaNNYbpCE0wD+OxyzKvi1sKkNikGurAtrJjnpqto2ZRaVGyqiK1gakRxQ+91optELbYbTQ SpfCnVwt1jlLzk2MY7SDwg==; In-Reply-To: <86zfslctt8.fsf@gmail.com> (eg642616@gmail.com) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319406 Archived-At: > From: "Elijah G." > Cc: emacs-devel@gnu.org > Date: Sun, 19 May 2024 16:37:07 -0600 > > Good news, the stipple implementation is now done, now works using > indent-bars package and other stipples, however there are some > issues that i want to remark > > 1. Currently it only works for stipple data and not for X Bitmap files, > I don't know where is stored the code for using X Bitmap in stipples. Please elaborate: what doesn't work yet with this implementation? > 2. I had to use `w32_create_pixmap_from_bitmap_data` for make it usable, > but it is defined before `image_create_bitmap_from_data`, i had to > copy its code for use it, Is there a problem move that function > before `image_create_bitmap_from_data` ? I don't understand the problem: in C there's no requirement to have a function defined before it is used. All you need is its prototype to be defined before the first use. > 3. The bitmap created using the copied code have colors inverted, > I fixed it setting text color to background color and bg to fg color, > I'm not sure how w32_create_pixmap_from_bitmap_data works, as far as > i could see it does some operations to the memory, something that i > don't think i can help so much. > > After fixing 1 (and maybe 2), I will only need to format the code (and > maybe rename XFillRectangle function) for send the final patch here. > > I'm attaching the work done if you all want to test it. Maybe I'm missing something, but where is the stipple in the attached image? Thanks.