From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71927: 29.4; ibuffer-do-isearch and ibuffer-do-isearch-regexp not prompting for input Date: Fri, 12 Jul 2024 10:03:19 +0300 Message-ID: <86r0bzks7c.fsf@gnu.org> References: <86ikxltzhx.fsf@mail.linkov.net> <861q49a8vt.fsf@gnu.org> <86y16h8olf.fsf@gnu.org> <878qyh79ov.fsf@gmx.net> <86zfqxqi6e.fsf@mail.linkov.net> <87v81l5aal.fsf@gmx.net> <864j9581zr.fsf@gnu.org> <87r0c957v2.fsf@gmx.net> <86y16h6llv.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14927"; mail-complaints-to="usenet@ciao.gmane.io" Cc: basil@contovou.net, stephen.berman@gmx.net, 71927@debbugs.gnu.org, kickingvegas@gmail.com, juri@linkov.net To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 12 09:04:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSAKP-0003g4-2x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Jul 2024 09:04:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sSAK3-0004fW-R0; Fri, 12 Jul 2024 03:04:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSAK2-0004Ur-2z for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 03:04:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sSAK1-0002qa-Qn for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 03:04:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sSAK1-0002Fg-Ru for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2024 03:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Jul 2024 07:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71927 X-GNU-PR-Package: emacs Original-Received: via spool by 71927-submit@debbugs.gnu.org id=B71927.17207678398648 (code B ref 71927); Fri, 12 Jul 2024 07:04:01 +0000 Original-Received: (at 71927) by debbugs.gnu.org; 12 Jul 2024 07:03:59 +0000 Original-Received: from localhost ([127.0.0.1]:53090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSAJy-0002FQ-WE for submit@debbugs.gnu.org; Fri, 12 Jul 2024 03:03:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:38150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sSAJu-0002FA-R1 for 71927@debbugs.gnu.org; Fri, 12 Jul 2024 03:03:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sSAJo-0002nw-SS; Fri, 12 Jul 2024 03:03:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=FblNH/k4wA4XDmCUvghD89G7DpPNyhcCysXZExIq/rw=; b=GaRIAPa9viTMqoYrzTtO Dw6a7o5Ch3MfRBfaKE/Mc6U2jVG6vfbKo7omgZp/XvxS5o4OeNW9l88CWVtQvbKeFHLzsAIuYeydj bFde9qZpb95RiRYblAwDfBIkeykOsxn/NyNR5zn+TG1aGbUeK8cV4PVk3N2PfpYUk1ee80gbirKNG T5IYEGL9/OhJoDdiDw3bKQG/06sC03UaiShZrathDVT3mmVFxZSGleNB8Fscqr/nCSD7LAI3t4hyG 3IGuXfMueRyiTWpAVQrHgZ1hhHMcLo2qAeR0j3E/Vh1TAct1jwpqGe81/hd1fJ6pFef2G4vRUbYDc oSLAT4kivzTdLw==; In-Reply-To: (message from Eshel Yaron on Sat, 06 Jul 2024 23:13:27 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:288764 Archived-At: > From: Eshel Yaron > Cc: Stephen Berman , juri@linkov.net, > kickingvegas@gmail.com, 71927@debbugs.gnu.org, basil@contovou.net > Date: Sat, 06 Jul 2024 23:13:27 +0200 > > Eli Zaretskii writes: > > >> I gave a mild counterargument upthread, that making > >> ibuffer-do-isearch{-regexp} defuns independent of define-ibuffer-op > >> seems like accepting the inadequacy of the latter instead of trying to > >> improve it. > > > > It is indeed inadequate for commands that just put Emacs in a special > > state and return, as opposed to commands that don't return before they > > did the complete job of operating on the marked buffers. > > Actually, there's another problem with the way ibuffer-do-isearch is > currently defined via define-ibuffer-op: the BODY of the definition is a > call to multi-isearch-buffers, but the BODY is called for each marked > buffer, not once for all of them, so this command currently calls > multi-isearch-buffers repeatedly when there are multiple marked buffers. > This causes multi-isearch-setup to be called while multi-buffer Isearch > is already in progress, which unfortunately breaks regular Isearch for > the rest of the session. > > To see this effect, invoke ibuffer-do-isearch with two or more marked > buffers, quit or finish the search (e.g. type C-g), and then try regular > Isearch with C-s and repeat C-s until wrapping around. But instead of > wrapping around as expected, Emacs displays an error: > > Symbol’s function definition is void: nil > > A simple solution is to use plain defun for these commands, as follows: Thanks. Since there were no objections in a week, and Juri also agreed with this solution, please install this on the emacs-30 branch.