From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Date: Sun, 25 Aug 2024 10:29:22 +0300 Message-ID: <86r0adkqlp.fsf@gnu.org> References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <86h6bcubn0.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21112"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 25 09:30:34 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1si7hp-0005Kq-IK for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Aug 2024 09:30:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1si7hY-0003Kq-NG; Sun, 25 Aug 2024 03:30:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si7hU-0003KX-Sv for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2024 03:30:14 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1si7hU-00067h-BX for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2024 03:30:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=jy5bGyFIiLhbONdtntfmfEIL75VYIZmkcD9oLNYzgf0=; b=pNN5tVFajZqZ1BjZfNA2d+Jt9OJhSKEUmaMoHX/P4nZn7i9utfVhdxfg3GL6kB6YcztnwwFxnbP/0dJ6QKG1ZdRNMBtDSA/SqPVE1t+XMldH2OnImznI7rv3iADkSkeAFUmVFA4eUN30CejiRBIy0j2tMkagz2CLZEOLCrIFiDLrOUQL2WJYkLOHVJz20wwgRd8AYlz/nK/e+1h612trNRpui1FFHjWtslH2/3zNInkmEXA246iwxnUDTGlEYV+4Wd9E8DbQl06vsqLKRmRcKe+9zIc3zxW0wSpDRJZPB8ig8cJ+4+LRP8/4pehseRLZ05+AjMoMbC9el++edr6Y5Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1si7iH-0004ZK-Nx for bug-gnu-emacs@gnu.org; Sun, 25 Aug 2024 03:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Aug 2024 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72721 X-GNU-PR-Package: emacs Original-Received: via spool by 72721-submit@debbugs.gnu.org id=B72721.172457102617501 (code B ref 72721); Sun, 25 Aug 2024 07:31:01 +0000 Original-Received: (at 72721) by debbugs.gnu.org; 25 Aug 2024 07:30:26 +0000 Original-Received: from localhost ([127.0.0.1]:42195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1si7hh-0004YC-Nj for submit@debbugs.gnu.org; Sun, 25 Aug 2024 03:30:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1si7hf-0004Xs-Hu for 72721@debbugs.gnu.org; Sun, 25 Aug 2024 03:30:24 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1si7gk-0005t8-5A; Sun, 25 Aug 2024 03:29:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jy5bGyFIiLhbONdtntfmfEIL75VYIZmkcD9oLNYzgf0=; b=PHaGRZ9bz4Cq 1kz/yPi2QYIm4whCl4EBHqpsWI9x8D8e/B999OhSRpwVJx9lS8pUKq8SbQs5SWVVV97Nb5nxv32MS Ef+KthESwzRUJtZB2Ym6ZsXfEERUVEbx1snxxMHHDx3bHsA+h9Ugf4/iAYaezQmwuINAYnX82Ht2i Z51BzC2myGWBqq9i32a/dPk1iuW1l6H5/W7KbcMG5izDkIDDDhTV4qT8fnqMx6Lm6oS84JUfudqBT u7DYu5OtxW5GHMjsL3dxS1uthfcaT+y6nDfPDeMobRMYXolO71bmyOTY209DHUcMCDyXc7xVCv+um wRodJHyqqdDRVXtlljOzIg==; In-Reply-To: (message from Jim Porter on Thu, 22 Aug 2024 09:19:47 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290728 Archived-At: > Date: Thu, 22 Aug 2024 09:19:47 -0700 > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > From: Jim Porter > > On 8/22/2024 2:53 AM, Eli Zaretskii wrote: > > Thanks for the test cases, they helped a lot. > > > > Can you please try the patch below, including in the original use case > > with Magit? I hope I've figured out all of the quirks of min-width > > and its possible uses, and the few extensions you demonstrated. It > > should be possible now to have min-width on overlay strings as well, I > > think (but I didn't test that). > > This works for me in all my test cases (except "overlay-min-width"), > including the original report with Magit. I also replaced > 'Fget_text_property' with 'Fget_char_property' in 'get_display_property' > and tested that: it works with all my test cases, including > "overlay-min-width". > > If you're not too worried about using 'Fget_char_property', I think that > would be the preferable patch, since it would (probably?) make it easier > for me to fix a small bug I noticed in 'visual-wrap-prefix-mode': I > neglected to remove the 'min-width' properties when deactivating the > mode. Using overlays for that might make it easier to wipe them out at > the right time. I made the change to use Fget_char_property and installed the changeset on the master branch. Please note that overlays can be window-specific, and the changes I installed are supposed to handle that, but I didn't test that too much. Please test with window-specific overlays and see if it works correctly; if not, I'd appreciate a test case for looking into the failure. Thanks.