From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz
Subject: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers
Date: Sun, 25 Aug 2024 10:29:22 +0300 [thread overview]
Message-ID: <86r0adkqlp.fsf@gnu.org> (raw)
In-Reply-To: <b58c5b04-f0c6-928e-34d8-89e5b041443a@gmail.com> (message from Jim Porter on Thu, 22 Aug 2024 09:19:47 -0700)
> Date: Thu, 22 Aug 2024 09:19:47 -0700
> Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 8/22/2024 2:53 AM, Eli Zaretskii wrote:
> > Thanks for the test cases, they helped a lot.
> >
> > Can you please try the patch below, including in the original use case
> > with Magit? I hope I've figured out all of the quirks of min-width
> > and its possible uses, and the few extensions you demonstrated. It
> > should be possible now to have min-width on overlay strings as well, I
> > think (but I didn't test that).
>
> This works for me in all my test cases (except "overlay-min-width"),
> including the original report with Magit. I also replaced
> 'Fget_text_property' with 'Fget_char_property' in 'get_display_property'
> and tested that: it works with all my test cases, including
> "overlay-min-width".
>
> If you're not too worried about using 'Fget_char_property', I think that
> would be the preferable patch, since it would (probably?) make it easier
> for me to fix a small bug I noticed in 'visual-wrap-prefix-mode': I
> neglected to remove the 'min-width' properties when deactivating the
> mode. Using overlays for that might make it easier to wipe them out at
> the right time.
I made the change to use Fget_char_property and installed the
changeset on the master branch. Please note that overlays can be
window-specific, and the changes I installed are supposed to handle
that, but I didn't test that too much. Please test with
window-specific overlays and see if it works correctly; if not, I'd
appreciate a test case for looking into the failure.
Thanks.
next prev parent reply other threads:[~2024-08-25 7:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 21:39 bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Gautier Ponsinet
2024-08-20 0:46 ` Jim Porter
2024-08-20 11:53 ` Eli Zaretskii
2024-08-20 17:33 ` Jim Porter
2024-08-20 19:01 ` Eli Zaretskii
2024-08-21 3:15 ` Jim Porter
2024-08-21 5:18 ` Jim Porter
2024-08-21 19:12 ` Jim Porter
2024-08-22 12:54 ` Eli Zaretskii
2024-08-22 9:59 ` Eli Zaretskii
2024-08-22 9:53 ` Eli Zaretskii
2024-08-22 16:19 ` Jim Porter
2024-08-25 7:29 ` Eli Zaretskii [this message]
2024-08-25 16:26 ` Jim Porter
2024-08-25 17:39 ` Eli Zaretskii
2024-08-25 18:41 ` Jim Porter
2024-08-29 11:47 ` Eli Zaretskii
2024-08-30 5:01 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r0adkqlp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=72721@debbugs.gnu.org \
--cc=gautier@gautierponsinet.xyz \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.