From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74111: [PATCH] New `tmm-menubar' shortcut display style Date: Fri, 01 Nov 2024 09:16:06 +0200 Message-ID: <86r07v1l1l.fsf@gnu.org> References: <87r07xtuot.fsf@ledu-giraud.fr> <86sesc37x4.fsf@gnu.org> <87msikin17.fsf@ledu-giraud.fr> <86ikt835sc.fsf@gnu.org> <87ikt8ijc1.fsf@ledu-giraud.fr> <86a5ek2vtv.fsf@gnu.org> <87frocz2bd.fsf@ledu-giraud.fr> <861pzw2osq.fsf@gnu.org> <87bjz0yliz.fsf@ledu-giraud.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74111@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 01 08:17:32 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6luV-0006uq-Dp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Nov 2024 08:17:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6luF-0004wx-Ct; Fri, 01 Nov 2024 03:17:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6lu2-0004w8-MG for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 03:17:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6lu2-0001dh-CX for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 03:17:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=rVLrz+DJt9OjHv/+qPbsCqLOqIAhMy+Mhw77lq9F1/M=; b=E/wjeJAWXcGDeRt93xm36xA6XP0apUuRwXQJMSscnyOUeJ5c25R/5HYQm+wIeWuFsnMZKvUp6k2dklYXrKflecL+uz9LxGLmRtzzhyPt254sAWxjgqsIc60l8/dU+Tp91rkQTktWuMcp5uFy81oh4k1eQtznDXDEmW+BJUnqWDViHnp63MUgpBA/ZUeui5NYdJpkPlmEFAsKssqE38V/UNKfeQGmX3aazlAttgqOl+6bXIz/8FDWxRFrgVJYCeJwMnG0buC/sRrJX1Un9fHpP6Bfod0P96WRbXk9XCiKXQ35bgnKa1gi5ZJThdecEBBtNdK2SSvOPd8BlBzFcPlheg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6lu2-0005US-7D for bug-gnu-emacs@gnu.org; Fri, 01 Nov 2024 03:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Nov 2024 07:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74111 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74111-submit@debbugs.gnu.org id=B74111.173044538021048 (code B ref 74111); Fri, 01 Nov 2024 07:17:02 +0000 Original-Received: (at 74111) by debbugs.gnu.org; 1 Nov 2024 07:16:20 +0000 Original-Received: from localhost ([127.0.0.1]:47378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6ltM-0005TQ-4h for submit@debbugs.gnu.org; Fri, 01 Nov 2024 03:16:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6ltK-0005TK-2U for 74111@debbugs.gnu.org; Fri, 01 Nov 2024 03:16:18 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6ltE-0001b3-D4; Fri, 01 Nov 2024 03:16:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rVLrz+DJt9OjHv/+qPbsCqLOqIAhMy+Mhw77lq9F1/M=; b=FA/DZbB5bWxk EJKWClrMjzOyQrsBAgs99XJemiekI12V8/DLiYn91hw/QVpCBWVdC0pOPamJLBYhdvPxXDedzmWQv PyL9hVoLKYaE9lREWiVihVdFDSKK14ptb+brUrPsjZmU8UKvHCoNaVWSlo+g83SnQcLZPWonrIWBY Hcx607YhNr5s2bRpIf2zjxTEAKNszL8IkZPmFAvTO5bkfcOp/Y0pgJf8+XMXIMvrLI6nMRbnd9T8X L/LMuZ9vrM16uklZ/+nu5o32xIBkDVVT47e3WtcuI4rUI+X/4FSpXwoXTYFuxg0hPsoLFr/4lhjjf 5Nef0bTeYi/jyfhOs1oHtw==; In-Reply-To: <87bjz0yliz.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 31 Oct 2024 23:07:00 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294659 Archived-At: > From: Manuel Giraud > Cc: 74111@debbugs.gnu.org > Date: Thu, 31 Oct 2024 23:07:00 +0100 > > Here is a new version taking your remarks into account. Thanks, just a few nits now: > +(defcustom tmm-shortcut-inside-entry nil > + "Highlight the shortcut character in the menu entry's string. > +When non-nil, the shortcut character will be highlighted into its menu > +entry's string with the `highlight' face to help identifying it. I'd rephrase the last sentence like this: When non-nil, the first menu-entry's character that acts as a shortcut will be highlighted with the `highlight' face to help identifying it. > + ;; A nil value for pos means that the shortcut is not inside the > + ;; string of the menu entry Please end this comment with a period. Likewise elsewhere in the patch.