all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Manuel Giraud <manuel@ledu-giraud.fr>
Cc: 74111@debbugs.gnu.org
Subject: bug#74111: [PATCH] New `tmm-menubar' shortcut display style
Date: Fri, 01 Nov 2024 09:16:06 +0200	[thread overview]
Message-ID: <86r07v1l1l.fsf@gnu.org> (raw)
In-Reply-To: <87bjz0yliz.fsf@ledu-giraud.fr> (message from Manuel Giraud on Thu, 31 Oct 2024 23:07:00 +0100)

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 74111@debbugs.gnu.org
> Date: Thu, 31 Oct 2024 23:07:00 +0100
> 
> Here is a new version taking your remarks into account.

Thanks, just a few nits now:

> +(defcustom tmm-shortcut-inside-entry nil
> +  "Highlight the shortcut character in the menu entry's string.
> +When non-nil, the shortcut character will be highlighted into its menu
> +entry's string with the `highlight' face to help identifying it.

I'd rephrase the last sentence like this:

  When non-nil, the first menu-entry's character that acts as a
  shortcut will be highlighted with the `highlight' face to help
  identifying it.

> +        ;; A nil value for pos means that the shortcut is not inside the
> +        ;; string of the menu entry

Please end this comment with a period.  Likewise elsewhere in the
patch.





  reply	other threads:[~2024-11-01  7:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-30 16:35 bug#74111: [PATCH] New `tmm-menubar' shortcut display style Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31  9:46 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 10:04 ` Eli Zaretskii
2024-10-31 10:28   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 10:50     ` Eli Zaretskii
2024-10-31 11:48       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 14:25         ` Eli Zaretskii
2024-10-31 16:04           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-10-31 16:57             ` Eli Zaretskii
2024-10-31 22:07               ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-01  7:16                 ` Eli Zaretskii [this message]
2024-11-01  9:31                   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-01 12:11                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86r07v1l1l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=74111@debbugs.gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.