From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: emacs-30 7c50e4cc8cc 2/2: Improve 'compilation-transform-file-match-alist' documentation Date: Wed, 04 Dec 2024 17:37:46 +0200 Message-ID: <86r06nzcfp.fsf@gnu.org> References: <173332205449.2846597.9153784089592444113@vcs3.savannah.gnu.org> <20241204142055.B1FEF5430D0@vcs3.savannah.gnu.org> <877c8feda3.fsf@gmail.com> <86v7vzzed7.fsf@gnu.org> <87y10vcwpk.fsf@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12317"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Robert Pluim Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 04 16:38:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tIrSJ-00030U-BO for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Dec 2024 16:38:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIrRn-0004ms-9G; Wed, 04 Dec 2024 10:37:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIrRl-0004mU-E0 for emacs-devel@gnu.org; Wed, 04 Dec 2024 10:37:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIrRl-0008Cg-5Q; Wed, 04 Dec 2024 10:37:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gnsT/8oPgK6ULwBPyXPblBAfrDFb876OfAquE+V7t6g=; b=Bt6bexw+Hvjw ywasquI39aF6TJasMOreIrq86wUoc7yXnrI1Hb8BUCNFVePRybv6KoSZeOrDI9qJDg2eiSLAFyPIB XhKBXzYVkHh5wut6isq+fR3a2jn1GswQXPBsKHeQT3F7ANShzfX3fZgOQAnluxkjkqhtm5/PcJn9C SQI3Iekb1J8Z3PIzJ4Cg9HoeaUiFM2oaUiToyJuomwcqteU8kXEg0zo0I1FzSTgqRdDbXSZDupe40 sLa5Iw80crDbp1mmPQjqOuxzG8wBlZKXQzJlg1RfAeA1vSdpCFNZcDsaqM7luMdi149Y1+y0kd/Kf qp1lUqtNieYWQ8DIkUaG3A==; In-Reply-To: <87y10vcwpk.fsf@gmail.com> (message from Robert Pluim on Wed, 04 Dec 2024 16:08:23 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326034 Archived-At: > From: Robert Pluim > Cc: emacs-devel@gnu.org > Date: Wed, 04 Dec 2024 16:08:23 +0100 > > >>>>> On Wed, 04 Dec 2024 16:56:04 +0200, Eli Zaretskii said: > > Eli> I don't think I'd mind to install on emacs-30, but if we are doing > Eli> this, why not do a better job? The tags above are not quite clear, to > Eli> say the least. "Match"? "Replace with"? does that really explain > Eli> itself? > > The docstring is supposed to explain it :-) How about: > > diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el > index ee7fc6aaecb..99385fcca07 100644 > --- a/lisp/progmodes/compile.el > +++ b/lisp/progmodes/compile.el > @@ -77,8 +77,9 @@ compilation-transform-file-match-alist > Similarly, to remove a prefix \"bar/\", use: > > (\"\\\\=`bar/\" \"\")" > - :type '(repeat (list regexp (choice (const :tag "No replacement" nil) > - string))) > + :type '(repeat (list (regexp :tag "Match filename(s)") > + (radio (const :tag "Not an error" nil) > + (string :tag "Replace match with")))) > :version "27.1") I think "Filename that matches", "Do not consider as error", and "Replace matched filename with", or something to that effect, will be better.