From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Brinkhoff Newsgroups: gmane.emacs.devel Subject: Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g Date: Tue, 28 Mar 2017 11:29:06 +0200 Organization: nocrew Message-ID: <86poh1iwbh.fsf@molnjunk.nocrew.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490693416 11016 195.159.176.226 (28 Mar 2017 09:30:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Mar 2017 09:30:16 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 28 11:30:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csnS6-0002Dl-2n for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 11:30:10 +0200 Original-Received: from localhost ([::1]:51932 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csnSC-0007l1-0x for ged-emacs-devel@m.gmane.org; Tue, 28 Mar 2017 05:30:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50926) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csnRd-0007kZ-OS for emacs-devel@gnu.org; Tue, 28 Mar 2017 05:29:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csnRZ-0004cy-QW for emacs-devel@gnu.org; Tue, 28 Mar 2017 05:29:41 -0400 Original-Received: from [195.159.176.226] (port=56639 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1csnRZ-0004cl-KK for emacs-devel@gnu.org; Tue, 28 Mar 2017 05:29:37 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1csnRK-0006Ig-7h for emacs-devel@gnu.org; Tue, 28 Mar 2017 11:29:22 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 37 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:46bEu0x2O0+UrWOKhoXim2FYGLY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:213438 Archived-At: Noam Postavsky wrote: > Make it easier to abort a series of tests with C-g > > * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If > interactively is true and a test was aborted then ask if the remaining > tests should be aborted too. > (ert-run-tests-batch, ert-run-tests-interactively): Pass in > interactively arg. This commit adds a testsuite failure when I run: git clean -xfd && ./autogen.sh && make bootstrap && make check If I revert this commit, the failure goes away. It seems there's a call to ert-run-tests that hasn't been updated with a third argument. >From test/lisp/emacs-lisp/ert-x-tests.el: Test ert-test-test-buffers backtrace: (let ((test-1 (progn "Constructor for objects of type `ert-test'." ( (let (buffer-1 buffer-2) (let ((test-1 (progn "Constructor for objec (lambda nil (let (buffer-1 buffer-2) (let ((test-1 (progn "Construct ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc ert-run-test([cl-struct-ert-test ert-test-test-buffers nil (lambda n ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes ert-run-tests((not (tag :expensive-test)) #[385 "\306\307\"\203G^@\2 ert-run-tests-batch((not (tag :expensive-test))) ert-run-tests-batch-and-exit((not (tag :expensive-test))) eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/ert-x-tes command-line() normal-top-level() Test ert-test-test-buffers condition: (wrong-number-of-arguments (3 . 3) 2) FAILED 9/9 ert-test-test-buffers