From: Lars Brinkhoff <lars@nocrew.org>
To: emacs-devel@gnu.org
Subject: Re: master ef44346 2/2: Make it easier to abort a series of tests with C-g
Date: Tue, 28 Mar 2017 11:29:06 +0200 [thread overview]
Message-ID: <86poh1iwbh.fsf@molnjunk.nocrew.org> (raw)
Noam Postavsky wrote:
> Make it easier to abort a series of tests with C-g
>
> * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If
> interactively is true and a test was aborted then ask if the remaining
> tests should be aborted too.
> (ert-run-tests-batch, ert-run-tests-interactively): Pass in
> interactively arg.
This commit adds a testsuite failure when I run:
git clean -xfd && ./autogen.sh && make bootstrap && make check
If I revert this commit, the failure goes away. It seems there's a call
to ert-run-tests that hasn't been updated with a third argument.
From test/lisp/emacs-lisp/ert-x-tests.el:
Test ert-test-test-buffers backtrace:
(let ((test-1 (progn "Constructor for objects of type `ert-test'." (
(let (buffer-1 buffer-2) (let ((test-1 (progn "Constructor for objec
(lambda nil (let (buffer-1 buffer-2) (let ((test-1 (progn "Construct
ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
ert-run-test([cl-struct-ert-test ert-test-test-buffers nil (lambda n
ert-run-or-rerun-test([cl-struct-ert--stats (not (tag :expensive-tes
ert-run-tests((not (tag :expensive-test)) #[385 "\306\307\"\203G^@\2
ert-run-tests-batch((not (tag :expensive-test)))
ert-run-tests-batch-and-exit((not (tag :expensive-test)))
eval((ert-run-tests-batch-and-exit (quote (not (tag :expensive-test)
command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/emacs-lisp/ert-x-tes
command-line()
normal-top-level()
Test ert-test-test-buffers condition:
(wrong-number-of-arguments
(3 . 3)
2)
FAILED 9/9 ert-test-test-buffers
next reply other threads:[~2017-03-28 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 9:29 Lars Brinkhoff [this message]
2017-03-28 13:48 ` master ef44346 2/2: Make it easier to abort a series of tests with C-g Noam Postavsky
2017-03-28 17:57 ` Lars Brinkhoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86poh1iwbh.fsf@molnjunk.nocrew.org \
--to=lars@nocrew.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.