From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: bignum branch
Date: Wed, 18 Jul 2018 10:28:36 +0100 [thread overview]
Message-ID: <86pnzkx58b.fsf@gmail.com> (raw)
In-Reply-To: 878t69g2cg.fsf@gmail.com
On Tue 17 Jul 2018, Robert Pluim wrote:
> The interpreter is fine. ccl.el assumes that 'ash' will truncate its
> result, which is no longer true when using bignums. Truncating all ash
> operations to 28 bits in ccl.el fixes this particular error for me,
> but the resulting CCL programs are not identical:
I tried something similar, by truncating the resulting CCL codewords to 28bits.
That fixes compiling the CCL program, but fails in the interpreter. You
can check by running some simple tests:
master (64bit mingw64 MSYS2):
ELISP> (require 'pgg)
pgg
ELISP> (seq-map (lambda (x) (format "#x%x" x)) pgg-parse-crc24)
("#x1" "#x1e" "#xe" "#x1c038" "#x1c057" "#x0" "#xa1" "#x20037"
"#x1" "#x242f9" "#xf" "#x140f7" "#x1" "#x738" "#x20057" "#x1"
"#x63b" "#x5" "#x100" "#x1c037" "#x186" "#x1c057" "#x4cfb"
"#x5bb" "#x10" "#x7" "#xb7" "#x1" "#x3fffffffffffea04"
"#x3fffffffffffe404" "#x16")
ELISP> (ccl-dump pgg-parse-crc24)
nil
ELISP> Out-buffer must be as large as in-buffer.
Main-body:
2:[read-register] read r0 (0 remaining)
3:[set-assign-expr-register] r1 ^= r0
4:[set-assign-expr-const] r2 ^= 0
6:[set-short-const] r5 = 0
7:[set-assign-expr-const] r1 <<= 1
9:[set-expr-const] r7 = r2 >> 15
11:[set-assign-expr-const] r7 &= 1
13:[set-assign-expr-register] r1 += r7
14:[set-assign-expr-const] r2 <<= 1
16:[jump-cond-expr-const] if !(r1 & 256), jump to 23(+7)
19:[set-assign-expr-const] r1 ^= 390
21:[set-assign-expr-const] r2 ^= 19707
23:[jump-cond-expr-const] if !(r5 < 7), jump to 29(+6)
26:[set-assign-expr-const] r5 += 1
28:[jump] jump to 7(-21)
29:[jump] jump to 2(-27)
At EOF:
30:[end] end
ELISP> (dolist (s '("foo" "bar" "baz"))
(let ((crc (pgg-parse-crc24-string s)))
(insert "\n" s " --> "
(mapconcat (lambda (b) (format "%02x" b)) crc ""))))
nil
ELISP>
foo --> 4fc255
bar --> 51d953
baz --> f0586a
bignum (64bit mingw64 MSYS2) with patch for `ash':
ELISP> (require 'pgg)
pgg
ELISP> (seq-map (lambda (x) (format "#x%x" x)) pgg-parse-crc24)
("#x1" "#x1f" "#xe" "#x1c038" "#x1c057" "#x0" "#xa2" "#x0" "#x20037"
"#x1" "#x242f9" "#xf" "#x140f7" "#x1" "#x738" "#x20057" "#x1"
"#x63b" "#x5" "#x100" "#x1c037" "#x186" "#x1c057" "#x4cfb" "#x5bb"
"#x10" "#x7" "#xb7" "#x1" "#xfffea04" "#xfffe304" "#x16")
ELISP> (ccl-dump pgg-parse-crc24)
nil
ELISP> Out-buffer must be as large as in-buffer.
Main-body:
2:[read-register] read r0 (0 remaining)
3:[set-assign-expr-register] r1 ^= r0
4:[set-assign-expr-const] r2 ^= 0
6:[set-const] r5 = 0
8:[set-assign-expr-const] r1 <<= 1
10:[set-expr-const] r7 = r2 >> 15
12:[set-assign-expr-const] r7 &= 1
14:[set-assign-expr-register] r1 += r7
15:[set-assign-expr-const] r2 <<= 1
17:[jump-cond-expr-const] if !(r1 & 256), jump to 24(+7)
20:[set-assign-expr-const] r1 ^= 390
22:[set-assign-expr-const] r2 ^= 19707
24:[jump-cond-expr-const] if !(r5 < 7), jump to 30(+6)
27:[set-assign-expr-const] r5 += 1
29:[jump] jump to 1048584(+1048555)
30:[jump] jump to 1048578(+1048548)
At EOF:
31:[end] end
ELISP> (dolist (s '("foo" "bar" "baz"))
(let ((crc (pgg-parse-crc24-string s)))
(insert "\n" s " --> "
(mapconcat (lambda (b) (format "%02x" b)) crc ""))))
*** Eval error *** Error in CCL program at 30th code
> Someone who know ccl should take a look (or we punt and remove pgg,
> since itʼs obsolete anyway).
If pgg is removed, the CCL interpreter and ccl.el should also be
removed.
AndyM
next prev parent reply other threads:[~2018-07-18 9:28 UTC|newest]
Thread overview: 205+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 4:26 bignum branch Tom Tromey
2018-07-13 7:38 ` Eli Zaretskii
2018-07-13 8:45 ` Robert Pluim
2018-07-13 9:51 ` Robert Pluim
2018-07-13 11:59 ` Eli Zaretskii
2018-07-13 13:31 ` Robert Pluim
2018-07-13 18:06 ` Tom Tromey
2018-07-13 12:04 ` Eli Zaretskii
2018-07-13 12:14 ` Eli Zaretskii
2018-07-13 13:02 ` Robert Pluim
2018-07-13 13:50 ` Eli Zaretskii
2018-07-15 16:29 ` Andy Moreton
2018-07-17 18:10 ` Robert Pluim
2018-07-17 18:24 ` Eli Zaretskii
2018-07-17 19:06 ` Eli Zaretskii
2018-07-17 20:00 ` Robert Pluim
2018-07-17 21:17 ` Clément Pit-Claudel
2018-07-18 1:01 ` Stefan Monnier
2018-07-18 9:28 ` Andy Moreton [this message]
2018-07-18 13:21 ` Robert Pluim
2018-07-18 13:32 ` Stefan Monnier
2018-07-18 16:01 ` Eli Zaretskii
2018-07-18 16:21 ` Robert Pluim
2018-07-18 16:47 ` Eli Zaretskii
2018-07-13 12:34 ` Robert Pluim
2018-07-13 14:28 ` Andy Moreton
2018-07-13 14:42 ` Eli Zaretskii
2018-07-13 14:53 ` Andy Moreton
2018-07-13 15:03 ` Eli Zaretskii
2018-07-13 15:30 ` Andy Moreton
2018-07-13 19:35 ` Andy Moreton
2018-07-14 16:20 ` Eli Zaretskii
2018-07-14 20:04 ` Andy Moreton
2018-07-15 13:46 ` Tom Tromey
2018-07-15 15:01 ` Eli Zaretskii
2018-07-16 12:19 ` Stefan Monnier
2018-07-16 14:40 ` Eli Zaretskii
2018-07-16 16:09 ` Stefan Monnier
2018-07-16 18:06 ` Eli Zaretskii
2018-07-16 18:32 ` Stefan Monnier
2018-07-16 18:42 ` Eli Zaretskii
2018-07-16 14:35 ` Tom Tromey
2018-07-16 22:28 ` Andy Moreton
2018-07-21 15:35 ` Andy Moreton
2018-07-22 16:43 ` Tom Tromey
2018-07-22 17:41 ` Andy Moreton
2018-08-03 0:43 ` Andy Moreton
2018-08-03 6:23 ` Eli Zaretskii
2018-08-03 9:01 ` Andy Moreton
2018-08-03 9:47 ` Eli Zaretskii
2018-08-03 10:07 ` Andy Moreton
2018-08-03 13:16 ` Eli Zaretskii
2018-08-03 14:05 ` Andy Moreton
2018-08-03 17:44 ` Eli Zaretskii
2018-08-03 19:54 ` Andy Moreton
2018-08-04 6:11 ` Eli Zaretskii
2018-08-04 11:14 ` Andy Moreton
2018-08-04 11:29 ` Eli Zaretskii
2018-08-03 20:17 ` Tom Tromey
2018-08-03 21:02 ` Paul Eggert
2018-08-03 21:19 ` Tom Tromey
2018-08-04 1:22 ` Paul Eggert
2018-08-04 6:18 ` Eli Zaretskii
2018-08-04 10:49 ` Achim Gratz
2018-08-04 11:07 ` Eli Zaretskii
2018-08-04 10:43 ` Achim Gratz
2018-08-04 16:33 ` Tom Tromey
2018-08-04 18:28 ` Achim Gratz
2018-08-04 6:20 ` Eli Zaretskii
2018-08-04 11:17 ` Andy Moreton
2018-08-04 16:41 ` Tom Tromey
2018-08-06 10:18 ` Robert Pluim
2018-08-07 0:36 ` Tom Tromey
2018-08-07 8:38 ` Andy Moreton
2018-08-08 0:25 ` Tom Tromey
2018-08-04 17:10 ` Tom Tromey
2018-08-03 17:30 ` Tom Tromey
2018-08-03 19:16 ` Andy Moreton
2018-08-04 6:07 ` Eli Zaretskii
2018-08-05 11:36 ` Andy Moreton
2018-08-05 15:18 ` Eli Zaretskii
2018-08-06 18:12 ` Andy Moreton
2018-08-07 0:41 ` Tom Tromey
2018-08-07 2:03 ` Paul Eggert
2018-08-07 3:59 ` Tom Tromey
2018-08-07 4:02 ` Tom Tromey
2018-08-07 11:22 ` Andy Moreton
2018-08-07 16:53 ` Paul Eggert
2018-08-07 17:12 ` Eli Zaretskii
2018-08-07 17:52 ` Paul Eggert
2018-08-08 0:23 ` Tom Tromey
2018-08-07 11:17 ` Andy Moreton
2018-08-08 0:26 ` Tom Tromey
2018-08-08 14:24 ` Andy Moreton
2018-08-08 16:35 ` Andy Moreton
2018-08-08 23:14 ` Tom Tromey
2018-08-09 2:33 ` Eli Zaretskii
2018-08-09 7:59 ` Michael Albinus
2018-08-09 13:01 ` Eli Zaretskii
2018-08-09 17:31 ` Paul Eggert
2018-08-09 18:32 ` Eli Zaretskii
2018-08-09 19:22 ` Stefan Monnier
2018-08-09 16:34 ` Tom Tromey
2018-08-09 18:28 ` Eli Zaretskii
2018-08-09 19:30 ` Tom Tromey
2018-08-08 23:37 ` Tom Tromey
2018-08-09 0:07 ` Andy Moreton
2018-08-09 2:03 ` Tom Tromey
2018-08-09 9:19 ` Andy Moreton
2018-08-09 20:49 ` Andy Moreton
2018-08-10 5:45 ` Eli Zaretskii
2018-08-10 7:43 ` Andy Moreton
2018-08-10 7:59 ` Paul Eggert
2018-08-10 9:48 ` Eli Zaretskii
2018-08-10 20:58 ` Paul Eggert
2018-08-11 7:08 ` Eli Zaretskii
2018-08-11 8:02 ` Paul Eggert
2018-08-11 10:50 ` Eli Zaretskii
2018-08-11 12:57 ` Stefan Monnier
2018-08-11 19:38 ` Paul Eggert
2018-08-10 11:18 ` Andy Moreton
2018-08-10 11:56 ` Andreas Schwab
2018-08-10 12:25 ` Eli Zaretskii
2018-08-10 12:27 ` Andy Moreton
2018-08-10 18:37 ` Achim Gratz
2018-08-10 12:26 ` Eli Zaretskii
2018-08-10 12:46 ` Andy Moreton
2018-08-10 9:46 ` Eli Zaretskii
2018-08-10 11:39 ` Andy Moreton
2018-08-10 12:33 ` Eli Zaretskii
2018-08-10 14:05 ` Andy Moreton
2018-08-10 19:57 ` Eli Zaretskii
2018-08-11 15:21 ` Andy Moreton
2018-08-11 15:25 ` Tom Tromey
2018-08-11 16:04 ` Eli Zaretskii
2018-08-11 16:16 ` Eli Zaretskii
2018-08-11 16:54 ` Andy Moreton
2018-08-11 17:34 ` Eli Zaretskii
2018-08-11 17:56 ` Andy Moreton
2018-08-11 18:10 ` Eli Zaretskii
2018-08-11 18:15 ` Andy Moreton
2018-08-11 19:08 ` Eli Zaretskii
2018-08-11 22:15 ` Andy Moreton
2018-08-12 18:54 ` Eli Zaretskii
2018-08-12 19:44 ` Andy Moreton
2018-08-13 15:02 ` Eli Zaretskii
2018-08-13 23:13 ` Andy Moreton
2018-08-14 14:55 ` Eli Zaretskii
2018-08-14 15:11 ` Andy Moreton
2018-08-14 15:19 ` Eli Zaretskii
2018-08-14 16:16 ` Andy Moreton
2018-08-15 17:01 ` Eli Zaretskii
2018-08-11 17:00 ` Andy Moreton
2018-08-10 15:25 ` Stefan Monnier
2018-08-10 16:45 ` Andy Moreton
2018-08-10 19:34 ` Eli Zaretskii
2018-08-09 3:49 ` Stefan Monnier
2018-08-09 9:21 ` Andy Moreton
2018-08-09 2:37 ` Eli Zaretskii
2018-08-03 20:13 ` Tom Tromey
2018-08-04 16:39 ` Tom Tromey
2018-08-04 17:24 ` Tom Tromey
2018-08-05 10:46 ` Andy Moreton
2018-08-05 18:59 ` Tom Tromey
2018-08-06 18:17 ` Andy Moreton
2018-07-15 15:00 ` Eli Zaretskii
2018-07-15 17:31 ` Paul Eggert
2018-07-15 18:27 ` Eli Zaretskii
2018-07-16 19:02 ` Paul Eggert
2018-07-17 2:42 ` Eli Zaretskii
2018-07-17 15:53 ` Paul Eggert
2018-07-17 17:03 ` Eli Zaretskii
2018-07-17 17:24 ` Paul Eggert
2018-07-17 17:38 ` Eli Zaretskii
2018-07-17 17:41 ` Paul Eggert
2018-07-17 17:53 ` Eli Zaretskii
2018-07-17 18:55 ` Paul Eggert
2018-07-17 19:04 ` Eli Zaretskii
2018-07-17 22:39 ` Paul Eggert
2018-07-18 2:41 ` Eli Zaretskii
2018-07-18 7:39 ` Paul Eggert
2018-07-18 11:14 ` Andy Moreton
2018-07-18 11:57 ` Paul Eggert
2018-07-18 13:09 ` Clément Pit-Claudel
2018-07-18 13:18 ` Stefan Monnier
2018-07-18 13:43 ` Clément Pit-Claudel
2018-07-18 14:06 ` Andy Moreton
2018-07-18 19:25 ` Achim Gratz
2018-07-18 20:41 ` Stefan Monnier
2018-07-19 2:36 ` Eli Zaretskii
2018-07-19 20:32 ` Paul Eggert
2018-07-20 20:02 ` Achim Gratz
2018-07-20 20:58 ` Paul Eggert
2018-07-20 21:48 ` Stefan Monnier
2018-07-22 19:49 ` Achim Gratz
2018-07-18 18:29 ` Paul Eggert
2018-07-18 11:10 ` Andy Moreton
2018-07-18 18:34 ` Paul Eggert
2018-07-25 21:02 ` Andy Moreton
2018-08-09 14:26 ` Charles A. Roelli
2018-08-09 15:17 ` Andy Moreton
2018-08-09 16:23 ` Charles A. Roelli
2018-08-09 16:25 ` Tom Tromey
2018-08-09 17:08 ` Andy Moreton
2018-08-09 19:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pnzkx58b.fsf@gmail.com \
--to=andrewjmoreton@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.