From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Problems with desktop.el after reecent local-mior-modes changes Date: Thu, 11 Mar 2021 20:59:03 +0000 Message-ID: <86pn05z9t4.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1140"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (windows-nt) To: emacs-devel@gnu.org Cancel-Lock: sha1:ijPDAaLZfxA4OSr20GuEW3dfHj8= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 11 22:00:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lKSQE-0000EQ-Ck for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 22:00:42 +0100 Original-Received: from localhost ([::1]:55270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lKSQD-0002y2-FM for ged-emacs-devel@m.gmane-mx.org; Thu, 11 Mar 2021 16:00:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKSOn-0002Jg-GU for emacs-devel@gnu.org; Thu, 11 Mar 2021 15:59:13 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:46168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lKSOm-0008Qi-AW for emacs-devel@gnu.org; Thu, 11 Mar 2021 15:59:13 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lKSOi-000964-Jw for emacs-devel@gnu.org; Thu, 11 Mar 2021 21:59:08 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266362 Archived-At: Hi, Has anyone else observed recent problems with desktop.el ? After updating master today (to commit 1d4195856b), I find that emacs built from the emacs-27 branch fails to restore a desktop save file, and complains that `local-minor-modes' is not defined as a variable. Desktop save files used to work interchangeably between branches up unito a few days ago, so there is a regression somewhere. Adding this to init.el suppresses the problem in emacs-27: (when (version< emacs-version "28") (defvar-local local-minor-modes nil)) ...however I'm not sure what saved state has not been restored. Is there some rework needed for desktop-minor-mode-handlers etc ? AndyM