From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#51648: 28.0.60; `tab-bar-close-button' and `tab-bar-new-button' should be documented in the manual Date: Thu, 27 Jan 2022 20:45:59 +0200 Organization: LINKOV.NET Message-ID: <86pmod5860.fsf@mail.linkov.net> References: <878ry0y884.fsf.ref@yahoo.com> <878ry0y884.fsf@yahoo.com> <83ee7sa17b.fsf@gnu.org> <878ry0whrm.fsf@yahoo.com> <83a6ig9zxc.fsf@gnu.org> <86h7cogg2d.fsf@mail.linkov.net> <835yt3962f.fsf@gnu.org> <864k8nrf5l.fsf@mail.linkov.net> <831r3r95bs.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9109"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: luangruo@yahoo.com, 51648@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 27 20:18:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDAHr-0002Ec-GU for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jan 2022 20:18:27 +0100 Original-Received: from localhost ([::1]:49350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDAHq-0005k7-Gf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jan 2022 14:18:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37812) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nD9oQ-0002Hg-Ml for bug-gnu-emacs@gnu.org; Thu, 27 Jan 2022 13:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nD9oQ-0003MT-Bw for bug-gnu-emacs@gnu.org; Thu, 27 Jan 2022 13:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nD9oQ-0004R4-BH for bug-gnu-emacs@gnu.org; Thu, 27 Jan 2022 13:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jan 2022 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51648 X-GNU-PR-Package: emacs Original-Received: via spool by 51648-submit@debbugs.gnu.org id=B51648.164330924316067 (code B ref 51648); Thu, 27 Jan 2022 18:48:02 +0000 Original-Received: (at 51648) by debbugs.gnu.org; 27 Jan 2022 18:47:23 +0000 Original-Received: from localhost ([127.0.0.1]:56574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nD9nm-0004As-Ne for submit@debbugs.gnu.org; Thu, 27 Jan 2022 13:47:22 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:35749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nD9nl-00044J-Dp for 51648@debbugs.gnu.org; Thu, 27 Jan 2022 13:47:21 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 954AD4000B; Thu, 27 Jan 2022 18:47:13 +0000 (UTC) In-Reply-To: <831r3r95bs.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Nov 2021 20:41:11 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225393 Archived-At: > Well, the request was to allow customization of the image on the tabs, > so maybe have just the image(s) customizable? I noticed that in addition that the button for tab-bar-format-menu-bar is not customizable, it also has a bug: `((menu-bar menu-item (propertize "Menu" 'face 'tab-bar-tab-inactive) tab-bar-menu-bar :help "Menu Bar"))) i.e. the part with (propertize "Menu" 'face 'tab-bar-tab-inactive) is inside the quoted list, but it should be unquoted with `,'. If it's ok to leave this bug in the release branch, then maybe this patch should be applied only to master? diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index d49fc2efea..4c95438bae 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -751,9 +751,13 @@ tab-bar-menu-bar (menu-bar-keymap)) (popup-menu menu event))) +(defvar tab-bar-menu-bar-button + (propertize "Menu" 'face 'tab-bar-tab-inactive) + "Button for the menu bar.") + (defun tab-bar-format-menu-bar () "Produce the Menu button for the tab bar that shows the menu bar." - `((menu-bar menu-item (propertize "Menu" 'face 'tab-bar-tab-inactive) + `((menu-bar menu-item ,tab-bar-menu-bar-button tab-bar-menu-bar :help "Menu Bar"))) --