all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, 51648@debbugs.gnu.org
Subject: bug#51648: 28.0.60; `tab-bar-close-button' and `tab-bar-new-button' should be documented in the manual
Date: Thu, 27 Jan 2022 20:45:59 +0200	[thread overview]
Message-ID: <86pmod5860.fsf@mail.linkov.net> (raw)
In-Reply-To: <831r3r95bs.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Nov 2021 20:41:11 +0200")

> Well, the request was to allow customization of the image on the tabs,
> so maybe have just the image(s) customizable?

I noticed that in addition that the button for tab-bar-format-menu-bar
is not customizable, it also has a bug:

  `((menu-bar menu-item (propertize "Menu" 'face 'tab-bar-tab-inactive)
     tab-bar-menu-bar :help "Menu Bar")))
 
i.e. the part with (propertize "Menu" 'face 'tab-bar-tab-inactive)
is inside the quoted list, but it should be unquoted with `,'.

If it's ok to leave this bug in the release branch,
then maybe this patch should be applied only to master?

diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
index d49fc2efea..4c95438bae 100644
--- a/lisp/tab-bar.el
+++ b/lisp/tab-bar.el
@@ -751,9 +751,13 @@ tab-bar-menu-bar
                 (menu-bar-keymap))
     (popup-menu menu event)))
 
+(defvar tab-bar-menu-bar-button
+  (propertize "Menu" 'face 'tab-bar-tab-inactive)
+  "Button for the menu bar.")
+
 (defun tab-bar-format-menu-bar ()
   "Produce the Menu button for the tab bar that shows the menu bar."
-  `((menu-bar menu-item (propertize "Menu" 'face 'tab-bar-tab-inactive)
+  `((menu-bar menu-item ,tab-bar-menu-bar-button
      tab-bar-menu-bar :help "Menu Bar")))
 
-- 





      parent reply	other threads:[~2022-01-27 18:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <878ry0y884.fsf.ref@yahoo.com>
2021-11-07  3:07 ` bug#51648: 28.0.60; `tab-bar-close-button' and `tab-bar-new-button' should be documented in the manual Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  7:12   ` Eli Zaretskii
2021-11-07  7:23     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07  7:40       ` Eli Zaretskii
2021-11-07  8:05         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-07 17:37         ` Juri Linkov
2021-11-07 18:25           ` Eli Zaretskii
2021-11-07 18:31             ` Juri Linkov
2021-11-07 18:41               ` Eli Zaretskii
2021-11-07 20:00                 ` Juri Linkov
2021-11-08  0:32                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-08  9:02                     ` Juri Linkov
2022-09-15 16:20                       ` Juri Linkov
2022-10-23 18:11                         ` Juri Linkov
2021-11-08 17:46                     ` Juri Linkov
2022-01-27 18:45                 ` Juri Linkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86pmod5860.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=51648@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.