From: Juri Linkov <juri@linkov.net>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: Paulo Sousa <de.sousa.paulus@gmail.com>, 55234@debbugs.gnu.org
Subject: bug#55234: 28.1; replace-string in rectangle regio
Date: Mon, 06 Jun 2022 10:43:20 +0300 [thread overview]
Message-ID: <86pmjmtexz.fsf@mail.linkov.net> (raw)
In-Reply-To: <87h750va36.fsf@web.de> (Michael Heerdegen's message of "Sat, 04 Jun 2022 15:20:45 +0200")
>> (defun rectangle--extract-region (orig &optional delete)
>> ...
>> (let* ((strs (funcall (if delete
>> #'delete-extract-rectangle
>> #'extract-rectangle)
>> - (region-beginning) (region-end)))
>> + ;; Avoid recursive calls
>> + (let (rectangle-mark-mode) (region-beginning))
>> + (let (rectangle-mark-mode) (region-end))))
>> (str (mapconcat #'identity strs "\n")))
>> (when (eq last-command 'kill-region)
>> ;; Try to prevent kill-region from appending this to some
>
> Is it intended to - at the end - call the original functions here?
Wouldn't it go to infinite recursion when the advice on region-beginning
will call region-bounds that calls rectangle--extract-region again?
next prev parent reply other threads:[~2022-06-06 7:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 22:36 bug#55234: 28.1; replace-string in rectangle regio Paulo Sousa
2022-05-03 6:57 ` Juri Linkov
2022-06-01 11:42 ` Michael Heerdegen
2022-06-01 19:23 ` Juri Linkov
2022-06-02 12:20 ` Michael Heerdegen
2022-06-02 17:19 ` Juri Linkov
2022-06-03 7:46 ` Juri Linkov
2022-06-03 18:09 ` Juri Linkov
2022-06-04 13:20 ` Michael Heerdegen
2022-06-06 7:43 ` Juri Linkov [this message]
2022-06-09 11:12 ` Michael Heerdegen
2022-06-09 17:05 ` Juri Linkov
2022-06-02 17:23 ` Juri Linkov
2022-06-03 9:37 ` Michael Heerdegen
2022-06-08 17:10 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pmjmtexz.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=55234@debbugs.gnu.org \
--cc=de.sousa.paulus@gmail.com \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.