From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#60001: [PATCH] Improve completion of treesit-check-indent command Date: Wed, 06 Sep 2023 09:53:05 +0300 Organization: LINKOV.NET Message-ID: <86pm2v22ri.fsf@mail.linkov.net> References: <7FDC90A2-7616-434D-9737-4463F083C3F2@gmail.com> <83358lqm2q.fsf@gnu.org> <83pm2w51vw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32868"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: stefankangas@gmail.com, mardani29@yahoo.es To: 60001@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 09:15:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qdmkw-0008Nf-Bp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 09:15:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qdmki-0006XS-9s; Wed, 06 Sep 2023 03:15:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qdmkf-0006Uj-Q2 for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 03:15:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qdmkf-00084F-He for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 03:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qdmkg-0002uE-D4 for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 03:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 07:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60001 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60001-submit@debbugs.gnu.org id=B60001.169398449011136 (code B ref 60001); Wed, 06 Sep 2023 07:15:02 +0000 Original-Received: (at 60001) by debbugs.gnu.org; 6 Sep 2023 07:14:50 +0000 Original-Received: from localhost ([127.0.0.1]:60680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdmkL-0002tO-PQ for submit@debbugs.gnu.org; Wed, 06 Sep 2023 03:14:50 -0400 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:55783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qdmkJ-0002tA-J3 for 60001@debbugs.gnu.org; Wed, 06 Sep 2023 03:14:40 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 3E1836000B; Wed, 6 Sep 2023 07:14:29 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Tue, 5 Sep 2023 13:40:53 -0700") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269487 Archived-At: >>> > If you agree with the change, please install it. >>> >>> It seems like this patch was never installed. Should it be? >> >> I think so, yes. > > Thanks, pushed to master as commit cd6dcfad107. Would it be possible to avoid code duplication in 'treesit--read-major-mode' with the same code as in 'read-file-local-variable-mode'? Maybe by creating a new core function to read a major mode?