From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#59486: completion-auto-wrap disobeyed by vertical navigation Date: Sun, 05 Nov 2023 19:53:23 +0200 Organization: LINKOV.NET Message-ID: <86pm0o84to.fsf@mail.linkov.net> References: <8635aayjm6.fsf@mail.linkov.net> <86zgchbj61.fsf@mail.linkov.net> <86r0lbuvrv.fsf@mail.linkov.net> <86a5rxwf9v.fsf@mail.linkov.net> <83a5rw8tho.fsf@gnu.org> <86il6kqhgn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9211"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: 59486@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 05 18:55:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qzhLW-0002GM-7F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 Nov 2023 18:55:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qzhLO-0007DB-DA; Sun, 05 Nov 2023 12:55:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qzhLJ-0007C8-Jz for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 12:55:25 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qzhLJ-0003Qy-2p for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 12:55:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qzhLt-00028f-Tm for bug-gnu-emacs@gnu.org; Sun, 05 Nov 2023 12:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Nov 2023 17:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59486 X-GNU-PR-Package: emacs Original-Received: via spool by 59486-submit@debbugs.gnu.org id=B59486.16992069318172 (code B ref 59486); Sun, 05 Nov 2023 17:56:01 +0000 Original-Received: (at 59486) by debbugs.gnu.org; 5 Nov 2023 17:55:31 +0000 Original-Received: from localhost ([127.0.0.1]:38130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzhLP-00027j-0W for submit@debbugs.gnu.org; Sun, 05 Nov 2023 12:55:31 -0500 Original-Received: from relay6-d.mail.gandi.net ([2001:4b98:dc4:8::226]:44697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qzhLN-00027U-95 for 59486@debbugs.gnu.org; Sun, 05 Nov 2023 12:55:29 -0500 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id CC3F5C0002; Sun, 5 Nov 2023 17:54:44 +0000 (UTC) In-Reply-To: <86il6kqhgn.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 02 Nov 2023 19:14:00 +0200") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273836 Archived-At: >> The argument zero to get-buffer-window AFAIU means that it will return >> non-nil when the buffer is shown in some window on an iconified frame, >> and I wonder why we would consider such a buffer "visible". > > (get-buffer-window "*Completions*" 0) is used everywhere in minibuffer.el > and simple.el, so the argument zero is for compatibility with other > minibuffer completion commands. During testing I discovered that the condition should be more complex. The problem is that the logic should be bound only to the minibuffer that showed the completions, not in other minibuffers within a set of recursive minibuffers. An example: `M-x TAB C-h v down RET' raised an error "Minibuffer is not active for completion". This error comes from `choose-completion-string', so I copied the same logic from `choose-completion-string': (when-let ((window (get-buffer-window "*Completions*" 0))) (when (eq (buffer-local-value 'completion-reference-buffer (window-buffer window)) (window-buffer (active-minibuffer-window))) cmd)) >> Same here. > > Here is a new patch: Now pushed the fixed patch.