From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67061: [PATCH] Improve syntax highlighting for python-ts-mode Date: Sat, 27 Jan 2024 11:49:37 +0200 Message-ID: <86plxn85se.fsf@gnu.org> References: <8734xdni6y.fsf@yandex.ru> <831qcwycbj.fsf@gnu.org> <83v8a3qh6m.fsf@gnu.org> <834jhadvkt.fsf@gnu.org> <7aee7e42-c07d-9131-18a9-4806f07d4267@gutov.dev> <83a5qw7izt.fsf@gnu.org> <172531702081590@mail.yandex.ru> <212931702208489@mail.yandex.ru> <0c6e2e14-b494-a8cb-3893-ffb39577baf9@gutov.dev> <7b17c99d-6e4b-43b3-af93-993901a3a4ea@gmail.com> <95071702343720@mail.yandex.ru> <78ffdcf3-e322-49ea-a0d5-d0485ade9e73@gmail.com> <7371702772641@mail.yandex.ru> <27502181702944649@mail.yandex.ru> <16489c3d-bddf-984b-6c98-2a1de9fdb6e8@gutov.dev> <43841703366539@mail.yandex.ru> <83le8ynuju.fsf@gnu.org> <83plxwtlrx.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20685"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67061@debbugs.gnu.org To: dmitry@gutov.dev, casouri@gmail.com, dvzubarev@yandex.ru Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 27 10:50:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTfKG-0005DQ-7X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Jan 2024 10:50:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTfK3-0004Ac-Qw; Sat, 27 Jan 2024 04:49:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTfK2-0004AU-VL for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 04:49:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTfJz-000767-0o for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 04:49:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTfK5-0007Jk-Ug for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 04:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2024 09:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67061 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67061-submit@debbugs.gnu.org id=B67061.170634899628109 (code B ref 67061); Sat, 27 Jan 2024 09:50:01 +0000 Original-Received: (at 67061) by debbugs.gnu.org; 27 Jan 2024 09:49:56 +0000 Original-Received: from localhost ([127.0.0.1]:53496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTfJz-0007JJ-DX for submit@debbugs.gnu.org; Sat, 27 Jan 2024 04:49:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTfJw-0007J3-Ng for 67061@debbugs.gnu.org; Sat, 27 Jan 2024 04:49:53 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTfJk-00075J-07; Sat, 27 Jan 2024 04:49:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dBStcDFFodqKjW+sU+WA08zkuu6Ygj/8vVezRmGrI5Q=; b=j3xCw/KTysfk BUIY6NK3N3tncUQ5zwNE9kO0Nf7kQgFFdSL19cVi3A9VyKb8sS0gwKQJ4gD1SPXgmWHuT9O4U9Mc0 BrEGfExHEOm4l16oVSiIB8JHZ7yYmXv+8j5szyvj1XM0W+NqBfkupF5QF5gJOuNp9aveldGv2iUGR q/kviTYSTccrYOeqNa1j5bg03z8HHFJpVwhDla6hiuk381Ge0XODslV//+7g6iICC1zwc/DzcTNk8 UWxVmhrshHLTvXQiWZCx2i0cBvF1FBy9M/40HW4NOWAfEU5mmE8TzQQmck2Zk86O+oRM7rjJHg8Xi wug0mNMeGJ4Y+vTvkSvy0g==; In-Reply-To: <83plxwtlrx.fsf@gnu.org> (message from Eli Zaretskii on Sat, 20 Jan 2024 11:08:18 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278983 Archived-At: Ping! Ping! Can this bug be closed now, or do we have anything left to do? > Cc: dvzubarev@yandex.ru, 67061@debbugs.gnu.org > Date: Sat, 20 Jan 2024 11:08:18 +0200 > From: Eli Zaretskii > > Ping! Should this bug be closed now? > > > Cc: casouri@gmail.com, dvzubarev@yandex.ru, 67061@debbugs.gnu.org > > Date: Tue, 09 Jan 2024 22:03:33 +0200 > > From: Eli Zaretskii > > > > > Date: Mon, 1 Jan 2024 19:42:16 +0200 > > > Cc: "67061@debbugs.gnu.org" <67061@debbugs.gnu.org> > > > From: Dmitry Gutov > > > > > > On 23/12/2023 23:45, Denis Zubarev wrote: > > > > Just adding a rule for highlighting CamelCase identifiers as types would > > > > lead to many false positives. For example, global variables or an object > > > > instantiation. > > > > > > It seems like the convention is to use ALL_CAPITAL for constants and > > > CamelCase for classes/constructors. Those can be distinguished with a > > > regexp, with single-char names being sorted into constants, which they > > > usually are. > > > > > > I suppose some code could be violating that, but perhaps we should > > > remind such authors about that with highlighting as well. > > > > > > Regarding object instantiation, I'd be happy to see the class name in > > > Class(...) instantiation calls highlighted with font-lock-type-face. > > > that's more useful that telling the user that they are seeing a function > > > call by the means of font-lock-function-call-face. > > > > Is there anything else left to do here, or should I close this bug? > > > > > > > > > > > >