From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v5] Add support for colored and styled underlines on tty frames Date: Sun, 10 Mar 2024 21:27:10 +0200 Message-ID: <86plw1vqep.fsf@gnu.org> References: <20240211180501.695192-1-mohkale@kisara.moe> <87bk8m1mq8.fsf@yahoo.com> <87wmqaf1oy.fsf@kisara.moe> <86v85uugki.fsf@gnu.org> <87msr6vte8.fsf@kisara.moe> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34534"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 10 20:27:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rjOps-0008lO-UY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Mar 2024 20:27:53 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rjOpW-00013u-G4; Sun, 10 Mar 2024 15:27:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjOpV-00013g-8H for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 15:27:29 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rjOpU-0002vv-WA for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 15:27:29 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rjOq2-0002Ut-8v for bug-gnu-emacs@gnu.org; Sun, 10 Mar 2024 15:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Mar 2024 19:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.17100988749586 (code B ref 62994); Sun, 10 Mar 2024 19:28:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 10 Mar 2024 19:27:54 +0000 Original-Received: from localhost ([127.0.0.1]:37909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjOpt-0002UY-Vb for submit@debbugs.gnu.org; Sun, 10 Mar 2024 15:27:54 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rjOps-0002UM-6L for 62994@debbugs.gnu.org; Sun, 10 Mar 2024 15:27:52 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rjOpF-0002tf-98; Sun, 10 Mar 2024 15:27:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DAilOz2fGiPW6FguaEXYaLfdhjZfQEB4i+bbukb093k=; b=HigIViOuFD6F zi273UO4MWAOA72ZwAp3gylHz9E2TG9x9TnBHCe/lAjJjSV8r8TmZR7p8Xwm2oFL/73lv2sQIXxfn HKEdcNP0036Bsg93TQWHAUVwg94epqxzUcX0qhwr7JK5a25Xw243VhjxgUsxEvsKCTC+NgoYj4/hu rNuEosoHgxU78V353gFULSVu4trS4b4wgtyfuTPjz7vK2B2Aat0boVYm/SxMVTWWf2S0caBXGIp2X mUtp6PlfZvyYSSUxZq/QDo1IhuxWnkFtqGUEhlc3XajSk1JUh7eePKIyHhm/l4OE+V28P6hN5T+vu uHe13X1u9kmQ/fSNsdAsUA==; In-Reply-To: <87msr6vte8.fsf@kisara.moe> (message from Mohsin Kaleem on Sun, 10 Mar 2024 18:22:39 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281431 Archived-At: > From: Mohsin Kaleem > Cc: luangruo@yahoo.com, 62994@debbugs.gnu.org > Date: Sun, 10 Mar 2024 18:22:39 +0000 > > Eli Zaretskii writes: > > > The "+++" thingy means the manuals were updated for this change, which > > is why Po Lu asked where are those updates. > > I see, does --- have a similar alternate meaning or can I just replace > the pluses with minuses? "---" means the change is so minor it will not require any manual changes. When in doubt leave the entry with neither "+++" nor "---". > >> Is this absolutely necessary? > > > > Not absolutely necessary, but very much preferred. It is unheard of > > in Emacs to have some face attribute that is supported on TTY frames > > but not on GUI frames. > > I see. If a blocker I'm happy to remove the extra underline styles? I'm > not sure how long it would take me to add GUI support and as I don't use > the GUI I'd be unlikely to prioritise it any time soon. I'm not sure it should be a blocker. > > No, you should mark the region and then press C-M-\. > > I see. So I should run this over all the lines I've changed to normalize > them? Yes.