From: Juri Linkov <juri@linkov.net>
To: Dmitry Gutov <dmitry@gutov.dev>
Cc: 70577@debbugs.gnu.org
Subject: bug#70577: [PATCH] New command other-project-prefix
Date: Wed, 22 May 2024 09:12:19 +0300 [thread overview]
Message-ID: <86plte1jro.fsf@mail.linkov.net> (raw)
In-Reply-To: <c5f43df3-7d80-4452-9ca8-8efeb9ab89f6@gutov.dev> (Dmitry Gutov's message of "Tue, 21 May 2024 23:16:55 +0300")
>> This works until I moved project-prompter to the beginning,
>> then 'C-x 5 p p' doesn't work with this:
>> (letrec ((root (funcall project-prompter))
>> (depth (minibuffer-depth))
>> (echofun (lambda () "[switch-project]"))
>> (around-fun
>> Maybe there is a better place?
>
> Last I checked, the project-prompter can change the value of this-command.
>
> Perhaps you can try a let-binding for this-command around the call to
> project-prompter, so that it's restored at the end.
This helps: (letrec ((root (let ((this-command this-command)) (funcall project-prompter)))
> Something to also be concerned about is having any of the display-buffer
> modifications, or other-project advices, get applied to one of the commands
> inside the project-prompter UI (if it's implemented using a sequence of
> commands). Perhaps I haven't triggered this case mostly by luck so far. How
> to guard against that? Maybe a dynamic variable of some sort. But then it'd
> also have to be checked uniformly in all such functions (hooks that prefix
> commands install).
This also helps:
diff --git a/lisp/window.el b/lisp/window.el
index 4147d7e6ebb..a4577d509b8 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -9252,7 +9279,7 @@ display-buffer-override-next-command
;; after the first display-buffer action (bug#39722).
(funcall clearfun)
new-window))))
- (command this-command)
+ (command this-original-command)
(echofun (when echo (lambda () echo)))
(exitfun
(lambda ()
@@ -9274,7 +9301,8 @@ display-buffer-override-next-command
(> (minibuffer-depth) minibuffer-depth)
;; But don't remove immediately after
;; adding the hook by the same command below.
- (eq this-command command))
+ (eq this-original-command command)
+ (get command 'prefix-command))
(funcall exitfun))))
;; Call post-function after the next command finishes (bug#49057).
(add-hook 'post-command-hook postfun)
But not sure about the latter, it might break some cases.
next prev parent reply other threads:[~2024-05-22 6:12 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 3:01 bug#70577: [PATCH] New command other-project-prefix Dmitry Gutov
2024-04-26 6:09 ` Juri Linkov
2024-04-26 10:59 ` Dmitry Gutov
2024-04-26 16:20 ` Dmitry Gutov
2024-04-28 12:13 ` Sean Whitton via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-28 15:56 ` Dmitry Gutov
2024-04-28 15:56 ` Dmitry Gutov
2024-04-28 16:46 ` Juri Linkov
2024-04-28 16:51 ` Juri Linkov
2024-04-28 21:40 ` Dmitry Gutov
2024-05-02 6:12 ` Juri Linkov
2024-05-04 2:12 ` Dmitry Gutov
2024-05-04 7:24 ` Eli Zaretskii
2024-05-04 17:22 ` Dmitry Gutov
2024-05-04 17:34 ` Eli Zaretskii
2024-05-05 0:02 ` Dmitry Gutov
2024-05-05 5:44 ` Eli Zaretskii
2024-05-05 18:26 ` Dmitry Gutov
2024-05-05 16:40 ` Juri Linkov
2024-05-05 18:55 ` Dmitry Gutov
2024-05-06 17:25 ` Juri Linkov
2024-05-06 18:30 ` Juri Linkov
2024-05-07 19:23 ` Dmitry Gutov
2024-05-09 6:24 ` Juri Linkov
2024-05-07 19:16 ` Dmitry Gutov
2024-05-09 2:22 ` Dmitry Gutov
2024-05-09 6:20 ` Juri Linkov
2024-05-10 1:46 ` Dmitry Gutov
2024-05-10 6:43 ` Juri Linkov
2024-05-10 15:09 ` Dmitry Gutov
2024-05-12 18:33 ` Dmitry Gutov
2024-05-14 6:23 ` Juri Linkov
2024-05-14 20:02 ` Dmitry Gutov
2024-05-15 6:46 ` Juri Linkov
2024-05-21 2:31 ` Dmitry Gutov
2024-05-21 6:08 ` Juri Linkov
2024-05-21 20:16 ` Dmitry Gutov
2024-05-22 6:12 ` Juri Linkov [this message]
2024-05-23 6:24 ` Juri Linkov
2024-05-26 2:38 ` Dmitry Gutov
2024-05-26 6:52 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plte1jro.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=70577@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.