From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71356: use-package doesn't load org from elpa Date: Wed, 05 Jun 2024 14:18:51 +0300 Message-ID: <86plsvk57o.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7662"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71356@debbugs.gnu.org, paaguti@gmail.com To: Andrea Corallo , Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 05 13:20:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEogk-0001nW-9x for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 05 Jun 2024 13:20:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEogH-0003Yg-E5; Wed, 05 Jun 2024 07:19:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEogG-0003YY-KE for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 07:19:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEogG-0000xY-C7 for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 07:19:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEogT-0005mA-TY for bug-gnu-emacs@gnu.org; Wed, 05 Jun 2024 07:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jun 2024 11:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71356 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71356-submit@debbugs.gnu.org id=B71356.171758635822085 (code B ref 71356); Wed, 05 Jun 2024 11:20:01 +0000 Original-Received: (at 71356) by debbugs.gnu.org; 5 Jun 2024 11:19:18 +0000 Original-Received: from localhost ([127.0.0.1]:53136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEofm-0005k7-3s for submit@debbugs.gnu.org; Wed, 05 Jun 2024 07:19:18 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:34602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEofj-0005ji-ML for 71356@debbugs.gnu.org; Wed, 05 Jun 2024 07:19:16 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEofP-0000lF-Il; Wed, 05 Jun 2024 07:18:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=0McILC/DJPlcSFMGmJ+TBzypN455M1gxHRJlvQOxT00=; b=rfcW1iVcMnKS8HVLeMb8 TK/M93HTpJKTXc5UM/+STOG2Jn3uePh57NEO1R8ST3F97gci5qgjgy2wXyHgG1o3B2Z2J5AS+tkHq SrHKrqm3Y1KxCoA5xqd+AZRPGP1Ul5lWzMo3vAGXTr6jBmLG9kJ4Gdr1a9yuq0tx4JmcBt8OsRFeb v5EvFZLOqjHVhojL/Gk67O+HaJ/yq7XOM1uc9PKp2ksQJh/Woo1vfyCwp6IeWDCdoVexIYNO4Z+3x fL84JMSIex4fXO05xFYEz7Ofk2CKFqRDgiHjZi+Ba2ZiN00sAi9mX+7mlW2LNeMRFIy1RpZiWJMut R4xbjfxG3ioZvw==; In-Reply-To: (message from Andrea Corallo on Tue, 04 Jun 2024 17:44:37 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286589 Archived-At: > Cc: 71356@debbugs.gnu.org > From: Andrea Corallo > Date: Tue, 04 Jun 2024 17:44:37 -0400 > > Seems the issue is in 'use-package-ensure-elpa' where we gate any > installation with "(unless (package-installed-p package)". I think we > should progress also if we see that the package is built-in and is > actually pinned. > > The attached seems to do the job for me, but I'm not 100% sure it's the > best/right fix so I'd appretiate someone else to have a look. Isn't this because we require an explicit directive by the user in order to upgrade a built-in package? The Emacs user manual says: By default, ‘package-install’ doesn't consider built-in packages for which new versions are available from the archives. (A package is built-in if it is included in the Emacs distribution.) In particular, it will not show built-in packages in the list of completion candidates when you type at its prompt. But if you invoke ‘package-install’ with a prefix argument, it will also consider built-in packages that can be upgraded. You can make this behavior the default by customizing the variable ‘package-install-upgrade-built-in’: if its value is non-‘nil’, ‘package-install’ will consider built-in packages even when invoked without a prefix argument. Note that the package-menu commands (*note Package Menu::) are also affected by ‘package-install-upgrade-built-in’. By contrast, ‘package-upgrade’ and ‘package-upgrade-all’ never consider built-in packages. If you want to use these commands for upgrading some built-in packages, you need to upgrade each of those packages, once, either via ‘C-u M-x package-install ’, or by customizing ‘package-install-upgrade-built-in’ to a non-‘nil’ value, and then upgrading the package once via the package menu or by ‘package-install’. We had a long (and somewhat heated) discussion about this a year ago, see bug#62720. Philip, am I missing something?