From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Including unconditionally in Emacs Date: Thu, 06 Jun 2024 07:53:46 +0300 Message-ID: <86plsuisdh.fsf@gnu.org> References: <1906c20b-1c6a-4fce-9e55-9667b32ec8f4@cs.ucla.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="371"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 06 06:54:39 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF594-000APl-IL for ged-emacs-devel@m.gmane-mx.org; Thu, 06 Jun 2024 06:54:38 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF58K-0002zP-QJ; Thu, 06 Jun 2024 00:53:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF58I-0002yq-Fn for Emacs-devel@gnu.org; Thu, 06 Jun 2024 00:53:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF58H-0001Tn-Br; Thu, 06 Jun 2024 00:53:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l/vGs/talxv/UhxX/DEIIn181RRKii4Nv+uUi7teL9A=; b=Cd9KxtN1Ndoz qWCYo4ZbbBzq+Ecm9NNFFPmZXoZ02zXOgz5TLD/J6RwktSKogcoi/AHhaWFvPj0ui22Bhtrdjtc1W M4hfwtMSL4R59+1066jWVtSWywmFWDf+5/vtnspA7fVHFvYu3T1SbPX0xI+rW0+4EkskyLr6GKhk0 HV8xinIbHY1FkEaZ390PyRJXiQ+8MoWg9KDUXrN03w3qqEGXogh3OCsH3dFdT5eah2XDBrsfM07Gu j6MkXR+1PUXl7+cs9rXW/JvEHWqGqchoHT/mMiPqrBAi4HyiaDu6l4gb/kSlb/TU+JwF9rSNxX800 Dedj2w4JRD94bQ62T+6puA==; In-Reply-To: <1906c20b-1c6a-4fce-9e55-9667b32ec8f4@cs.ucla.edu> (message from Paul Eggert on Wed, 5 Jun 2024 13:18:42 -0700) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319839 Archived-At: > Date: Wed, 5 Jun 2024 13:18:42 -0700 > From: Paul Eggert > > was standardized in C89, and all C platforms in current use > have it, if only to supply a dummy implementation with only a C locale. > However, the Emacs C source code currently attempts to port to platforms > lacking with code like this (though details vary): > > #ifdef HAVE_SETLOCALE > # include > #endif > > This sort of code dates back to the 1990s when some older platforms > predating C89 support presumably lacked and setlocale. > > As Emacs surely long ago stopped porting to platforms so obsolete that > they lack , I assume it would be OK for Emacs to start > including unconditionally. I thought I'd ask here first, > though, just to make sure. I think this is okay as far as modern Posix systems, MS-Windows and even MS-DOS are concerned, but I'd like to hear from Po Lu wrt the Andriod port, as I'm not familiar with the situation there. I think Po Lu also builds Emacs on some ancient Solaris version, so maybe there's an issue there? And what about macOS? In any case, please don't make this change in Emacs until after the emacs-30 release branch is cut (which should happen soon). And if the Gnulib folks are going to make that change in Gnulib now, it means we will have one more reason not to import from Gnulib before the branch point. Thanks.