all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Emacs-devel@gnu.org
Subject: Re: Including <locale.h> unconditionally in Emacs
Date: Thu, 06 Jun 2024 07:53:46 +0300	[thread overview]
Message-ID: <86plsuisdh.fsf@gnu.org> (raw)
In-Reply-To: <1906c20b-1c6a-4fce-9e55-9667b32ec8f4@cs.ucla.edu> (message from Paul Eggert on Wed, 5 Jun 2024 13:18:42 -0700)

> Date: Wed, 5 Jun 2024 13:18:42 -0700
> From: Paul Eggert <eggert@cs.ucla.edu>
> 
> <locale.h> was standardized in C89, and all C platforms in current use 
> have it, if only to supply a dummy implementation with only a C locale. 
> However, the Emacs C source code currently attempts to port to platforms 
> lacking <locale.h> with code like this (though details vary):
> 
>   #ifdef HAVE_SETLOCALE
>   # include <locale.h>
>   #endif
> 
> This sort of code dates back to the 1990s when some older platforms 
> predating C89 support presumably lacked <locale.h> and setlocale.
> 
> As Emacs surely long ago stopped porting to platforms so obsolete that 
> they lack <locale.h>, I assume it would be OK for Emacs to start 
> including <locale.h> unconditionally. I thought I'd ask here first, 
> though, just to make sure.

I think this is okay as far as modern Posix systems, MS-Windows and
even MS-DOS are concerned, but I'd like to hear from Po Lu wrt the
Andriod port, as I'm not familiar with the situation there.  I think
Po Lu also builds Emacs on some ancient Solaris version, so maybe
there's an issue there?  And what about macOS?

In any case, please don't make this change in Emacs until after the
emacs-30 release branch is cut (which should happen soon).  And if the
Gnulib folks are going to make that change in Gnulib now, it means we
will have one more reason not to import from Gnulib before the branch
point.

Thanks.



  reply	other threads:[~2024-06-06  4:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-05 20:18 Including <locale.h> unconditionally in Emacs Paul Eggert
2024-06-06  4:53 ` Eli Zaretskii [this message]
2024-06-06  5:44   ` Paul Eggert
2024-06-06  5:57     ` Eli Zaretskii
2024-06-06  6:46       ` Po Lu
2024-06-06  7:02         ` Stefan Kangas
2024-06-23 12:32     ` Stefan Kangas
2024-06-23 12:38       ` Eli Zaretskii
2024-06-08  2:54 ` Richard Stallman
2024-06-08  6:46   ` Eli Zaretskii
2024-06-11 15:01     ` Richard Stallman
2024-06-23  9:16     ` Björn Bidar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86plsuisdh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=Emacs-devel@gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.