From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#71786: 30.0.60; Compiler warnings in the Cygwin-w32 build Date: Wed, 26 Jun 2024 21:41:55 +0300 Message-ID: <86pls37dho.fsf@gnu.org> References: <02c4cbd6-dddb-4dc5-a85e-9abbbc46e6d2@cornell.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23367"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71786@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 26 20:43:35 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sMXcF-0005tR-9G for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 Jun 2024 20:43:35 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sMXc0-0003Oc-J8; Wed, 26 Jun 2024 14:43:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMXbo-0003Ni-49 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2024 14:43:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sMXbg-0000CZ-65 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2024 14:43:07 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sMXbi-00065R-CP for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2024 14:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2024 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71786 X-GNU-PR-Package: emacs Original-Received: via spool by 71786-submit@debbugs.gnu.org id=B71786.171942732823323 (code B ref 71786); Wed, 26 Jun 2024 18:43:02 +0000 Original-Received: (at 71786) by debbugs.gnu.org; 26 Jun 2024 18:42:08 +0000 Original-Received: from localhost ([127.0.0.1]:40261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMXaq-000647-0X for submit@debbugs.gnu.org; Wed, 26 Jun 2024 14:42:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37662) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sMXan-00063Y-MV for 71786@debbugs.gnu.org; Wed, 26 Jun 2024 14:42:06 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sMXaf-00007e-CO; Wed, 26 Jun 2024 14:41:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=IJ95Ws3kyW2I7hsIOFZM5VWU6kqc27sUXJ2hf9/Nlis=; b=jw9+RwyS2EiZE9TPtMeH MJTU3aGsB3J0AQRk5c64lXn8TzHJSSdyAcm5SHsKATKpAKRYGA80ioKUXk4lBFL2+s0VJG5gXfP0W XhGS/Ly/VALucPa8jGLHhqcqvK1QiPA4fYyNQSVREymXP6d9aX+BPc1Zpy4OzHeO9yGVI/zbZhdBy Gus6QV2+vH52orJx6wDRY0x4FoItOXW5dbvdj66pR+P++R0xOdrwzRCfj4845xpS4VA8XzbUCKunZ 7GI2Rpxki5qBiIv68jjFPaKZ80GjCqPtlF3XQs38rSiWWArRYVC7aRYoorF3Z+bgFllRqI4iImndV 0eNpI7Yo0n/hiQ==; In-Reply-To: <02c4cbd6-dddb-4dc5-a85e-9abbbc46e6d2@cornell.edu> (message from Ken Brown on Wed, 26 Jun 2024 14:22:43 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:287960 Archived-At: > Date: Wed, 26 Jun 2024 14:22:43 -0400 > From: Ken Brown > > The following warnings occur in the Cygwin-w32 build, on both the > emacs-30 and the master branch: > > ../../src/w32fns.c: At top level: > ../../src/w32fns.c:10581:1: warning: no previous prototype for ‘w32_get_resource’ > [-Wmissing-prototypes] > 10581 | w32_get_resource (const char *key, const char *name, LPDWORD lpdwtype) > | ^~~~~~~~~~~~~~~~ > ../../src/w32fns.c:11288: warning: macro "DEFAULT_IMAGE_BASE" is not used [-Wunused-macros] > 11288 | # define DEFAULT_IMAGE_BASE (ptrdiff_t)0x01000000 > | > > This fixes them on both branches: > > diff --git a/src/cygw32.h b/src/cygw32.h > index cc3414a39d92..2f265cab4adf 100644 > --- a/src/cygw32.h > +++ b/src/cygw32.h > @@ -35,5 +35,6 @@ #define CYGW32_H > > extern void syms_of_cygw32 (void); > extern char * w32_strerror (int error_no); > +extern LPBYTE w32_get_resource (const char * key, const char * name, LPDWORD type); > > #endif /* CYGW32_H */ > diff --git a/src/w32fns.c b/src/w32fns.c > index b784a9a563d7..4c2f18abd084 100644 > --- a/src/w32fns.c > +++ b/src/w32fns.c > @@ -11284,7 +11284,7 @@ #define BACKTRACE_LIMIT_MAX 62 > configure.ac. */ > #if defined MINGW_W64 && EMACS_INT_MAX > LONG_MAX > # define DEFAULT_IMAGE_BASE (ptrdiff_t)0x400000000 > -#else /* 32-bit MinGW build */ > +#elif !defined CYGWIN /* 32-bit MinGW build */ > # define DEFAULT_IMAGE_BASE (ptrdiff_t)0x01000000 > #endif > > OK for the emacs-30 branch? Yes, thanks.