From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72272: [PATCH] dired-hide-details-mode hides directory's absolute path Date: Sun, 04 Aug 2024 11:06:09 +0300 Message-ID: <86plqosoem.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31133"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72272@debbugs.gnu.org To: Alvaro Ramirez , Stefan Monnier , Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 04 10:06:56 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1saWGV-0007v7-Mu for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Aug 2024 10:06:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1saWGJ-0001Fy-Fr; Sun, 04 Aug 2024 04:06:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saWGH-0001Fl-Qm for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 04:06:41 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1saWGH-0005gB-Hf for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 04:06:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=iv0/XYjejufGWDV5Hy4juJJslcYsfDnw0uJmCHXv94g=; b=hMljtniqlgm6dKNgDUqX/8bzd3cQbhcVxDWC+r914l0lJzPC5a2rn6hlfjlfV0KAIfotwtKQRf97fVoM8HLTa0w1iQ0Z6xvZaxA8zNolTglUcIXzF3eyZynHXRBScq0sZcsZGFQkvCIG0I6IQzyYqQgVdOpjPyBemFLT/NOERrmYCIeBWu9xnofWlbpvlxywOM/knPYXj8PLrlbm7b8RdVIpibFnsWWvSkhphWuYmS2murnBqCKdxjk4s+Zxv2TANtbrS2WqF0/fmYytmt0LZNDkERpQSQ+0WEay7JYy51Qf6qqNMwG8CmaAhqgsAwj/96V3eUgWKBOODkHZr2inqQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1saWGc-0005dB-98 for bug-gnu-emacs@gnu.org; Sun, 04 Aug 2024 04:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Aug 2024 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72272 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 72272-submit@debbugs.gnu.org id=B72272.172275880421594 (code B ref 72272); Sun, 04 Aug 2024 08:07:02 +0000 Original-Received: (at 72272) by debbugs.gnu.org; 4 Aug 2024 08:06:44 +0000 Original-Received: from localhost ([127.0.0.1]:55409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saWGJ-0005cB-PJ for submit@debbugs.gnu.org; Sun, 04 Aug 2024 04:06:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1saWGH-0005bh-5B for 72272@debbugs.gnu.org; Sun, 04 Aug 2024 04:06:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1saWFq-0005dm-Cv; Sun, 04 Aug 2024 04:06:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iv0/XYjejufGWDV5Hy4juJJslcYsfDnw0uJmCHXv94g=; b=EhAI+zH3Sg2s oJZkeob5SFWAl+NTz0XPQhxPC6o6WeexpZhI4WQsO0zqp3o2Et1zCFwn4INFO2QvPquCIxwVS4uwj eGlF5nMbY66YiEb1tfcQn0kA8SX0JS4XQ0Po66UJY9LJCj5+11BA9aV3Bv9o5RvCkkR7FX7acaVTu 8rI8Uz/FdSh+ULgyj2gQH+XR8/q+iv0s9P04EbHhg+ddePAV8OcGWmt98uEOFwzDd6HRDwv4yrWAS rmM8jC+rDh1Ph7V42IwNNNpEWGKb+pZuwYxYjLK9iRuxHs7ZmUVrIX5++V8oPszcD1toeuuidf1+Y 2pHHbDNj2hKetSDmZ+AK+w==; In-Reply-To: (message from Alvaro Ramirez on Wed, 24 Jul 2024 12:17:58 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289724 Archived-At: > From: Alvaro Ramirez > Date: Wed, 24 Jul 2024 12:17:58 +0100 > > Hi folks, > > Sending an initial patch. Happy to iterate on it, add tests, > etc. if we > reckon the feature is worth pursuing. > > Set `dired-hide-details-hide-absolute-location` to non-nil and > toggle > `dired-hide-details-mode` to hide the current directory's absolute > path. > > This is my first submission, might need some process guidance. Thanks. Stefan and Andrea, any comments? I have a few minor ones: > From: xenodium > Date: Tue, 23 Jul 2024 21:55:37 +0100 > Subject: [PATCH] Hides current location's path via dired-hide-details-mode ^^^^ Please don't use "path" for anything except PATH-style directory lists. The GNU Coding Standards frown on such usage. > +(defcustom dired-hide-details-hide-absolute-location t > + "Non-nil means `dired-hide-details-mode' hides current location's absolute path." Same here. > + (if-let ((dir-base (file-name-nondirectory new-dir-name)) > + (dir-path (file-name-directory new-dir-name)) > + (hide-dir-path (and dired-hide-details-hide-absolute-location And here. Also, this change needs a NEWS entry.