From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#72721: 31.0.50; Visual-wrap-prefix-mode breaks Magit log buffers Date: Thu, 22 Aug 2024 15:54:27 +0300 Message-ID: <86plq0soos.fsf@gnu.org> References: <87cym4ry3e.fsf@gautierponsinet.xyz> <49828281-6a20-3791-91bd-9708ec51eb57@gmail.com> <86jzgbwgud.fsf@gnu.org> <36584786-6af4-c59f-bb3e-f3459b2904be@gmail.com> <86r0ajuigi.fsf@gnu.org> <378d3451-12b8-c802-4340-12e432bcaa35@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8316"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 22 14:55:40 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sh7Lo-0001wy-3D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Aug 2024 14:55:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sh7LS-0007TM-MP; Thu, 22 Aug 2024 08:55:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh7LQ-0007SU-K7 for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 08:55:16 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sh7LQ-0001js-90 for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 08:55:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=QQIu10KEw5bz3Nwtg1CViJ30r5nxnoIitCG+fy7bIP4=; b=JpQn6TETC6WJDpSXWdWRkccKldv3tBbxrJOcqKYKIsCbfAd/W24XfPS+hq2L1sMFSLUrEJp6x5pQuqyq3K7H9I4kzDT+qlyQyHmtuK3Izvf/2IMBHwQbboTZawso0XOLFuYTq1O+dVsT4JzToKS6l6DzqFUXMRror9wJXkkG9M6eK49ygpm82HGHpQRW3fi4q0NC6FpomX0wu2jS220QE9BFpza/8kkHwCnvwDc0F59VQJXdN05SHQb5ErDgb9W7L07cK15Pjuj693DvwUyJUFPgAwJhbC7SA2OaqrG47LcVck/8y2U0Aaf3YV030AHCCXFkQP0BlijBiqC4hoaong==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sh7M9-0001G6-Ko for bug-gnu-emacs@gnu.org; Thu, 22 Aug 2024 08:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Aug 2024 12:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72721 X-GNU-PR-Package: emacs Original-Received: via spool by 72721-submit@debbugs.gnu.org id=B72721.17243313304782 (code B ref 72721); Thu, 22 Aug 2024 12:56:01 +0000 Original-Received: (at 72721) by debbugs.gnu.org; 22 Aug 2024 12:55:30 +0000 Original-Received: from localhost ([127.0.0.1]:37038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh7Le-0001F3-GS for submit@debbugs.gnu.org; Thu, 22 Aug 2024 08:55:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sh7La-0001Em-E7 for 72721@debbugs.gnu.org; Thu, 22 Aug 2024 08:55:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sh7Kj-0001WE-Q3; Thu, 22 Aug 2024 08:54:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QQIu10KEw5bz3Nwtg1CViJ30r5nxnoIitCG+fy7bIP4=; b=dHCu1KkN6hLo iPF5EvtXWFWBYZmxCEssvBWWr4v1YJZQMcfI0iv2xvHmispWDBscfuVSJ0D5gqs8O8HAtYfSs91mA uEuIYxmSo4utmQSUSLsM1wM6gKixIsUDZqyfvsoOO6Fhkq0V2eHN8kNnwS+Ew/jizcWpjebbbgeoL gc4PE/gyeQAMcwO4pPWzlalna8QEv1KtHAUKEldBbXRgwBwuRgzMQKDT9EJG1iRZE9tafqF+Qsv9e kn6IYRoOPWXxV07PcEp6eNRBgsAFlqrIdjl4ydDT5ds2d+6bFK6pYjsBRtdgL4RWjbLw6H0zmcO3r bOgWz+SdIjbT+mVChvwSSA==; In-Reply-To: <378d3451-12b8-c802-4340-12e432bcaa35@gmail.com> (message from Jim Porter on Wed, 21 Aug 2024 12:12:00 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290535 Archived-At: > Date: Wed, 21 Aug 2024 12:12:00 -0700 > From: Jim Porter > Cc: 72721@debbugs.gnu.org, gautier@gautierponsinet.xyz > > ... and here's a new test case (overlay-min-width). This shows that now > you can apply 'min-width' as an overlay property, which would be great > for 'visual-wrap-prefix-mode'. I could then convert that code to use > overlays (at least for 'min-width', maybe for 'wrap-prefix' too), which > would make it easier to clean up when deactivating the mode. Doesn't adding support for overlays boils down to replacing Fget_text_property in get_display_property with Fget_char_property, and otherwise keeping the code intact? display_min_width is the only caller of get_display_property, so we can change that at will.