From: Eli Zaretskii <eliz@gnu.org>
To: Aleksandr Vityazev <avityazev@disroot.org>
Cc: 73357@debbugs.gnu.org
Subject: bug#73357: [PATCH] Make vc-clone interactive
Date: Thu, 19 Sep 2024 16:36:12 +0300 [thread overview]
Message-ID: <86ploz935f.fsf@gnu.org> (raw)
In-Reply-To: <875xqrlr3b.fsf@disroot.org> (bug-gnu-emacs@gnu.org)
> Date: Thu, 19 Sep 2024 16:18:16 +0300
> From: Aleksandr Vityazev via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> Cloning is used quite often, so I would like to have an interactive
> command. A patch is attached to the email. WDYT?
Thanks, but making this function a command will take more than just
adding the interactive form. I think we need at least:
. mention that in interactive usage the command prompts for the
argument (why do we have to prompt for REV, btw?)
. announce the change in NEWS
. maybe update the user manual
. maybe make the command fall back to 'checkout' method if 'clone'
is not supported
> + (when (file-directory-p directory)
> + (if (called-interactively-p 'interactive)
> + (find-file directory)
> + directory))))
This changes the value returned by the function from what it did
before, no?
next prev parent reply other threads:[~2024-09-19 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 13:18 bug#73357: [PATCH] Make vc-clone interactive Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-09-19 13:36 ` Eli Zaretskii [this message]
2024-09-19 16:38 ` Aleksandr Vityazev via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ploz935f.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=73357@debbugs.gnu.org \
--cc=avityazev@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.