From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joost Kremers Newsgroups: gmane.emacs.bugs Subject: bug#73355: 29.4; eglot-rename reports success when it shouldn't Date: Sun, 22 Sep 2024 00:04:52 +0200 Message-ID: <86plowslx7.fsf@fastmail.fm> References: <86plozvomz.fsf@fastmail.fm> <864j6947n1.fsf@gnu.org> <86zfo1kxx4.fsf@fastmail.fm> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12168"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73355@debbugs.gnu.org, Eli Zaretskii To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 22 00:06:05 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss8Eu-0002zP-6q for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Sep 2024 00:06:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss8EZ-0007hm-Rq; Sat, 21 Sep 2024 18:05:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss8EY-0007hc-6A for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 18:05:42 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ss8EX-0003YV-Sn for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 18:05:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=2xqXoYv39FBydBggSrEOklOfgtZIGDQajTXEYu/+KrM=; b=U/QVE4UgtETnFXsS/xpBslrltITZdjxdktDwzjVTG3Y4fltSKag7dbppWCRmerEn5FRaPhi6jHYGKkVNYbV7OJdqq268qmAi105eQk4gebzkd3dE6L/jAVPOJnI+3sVN6JXiMtJ6jU7SXWb9Kt/qP2J+VyLJQgwxmD4pNF7KEilphZYEss74UT3H+qWIJgRDKTilgJT5ukObMXpFDqBifdKV5RJTr+jpjmCQd11vb+LEocP7Cz1GuU8Rwz/UJ2BD3+g3+fp7xlpC5aBLMHd8tGzNRu9ebrZ/D91OPr+ZrEkFWioCiFjbNBuZm/tlPHRRBuXr6EQ2IVuUZvBXFdT8AQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ss8Es-0002uV-HZ for bug-gnu-emacs@gnu.org; Sat, 21 Sep 2024 18:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joost Kremers Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Sep 2024 22:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73355 X-GNU-PR-Package: emacs Original-Received: via spool by 73355-submit@debbugs.gnu.org id=B73355.172695632610808 (code B ref 73355); Sat, 21 Sep 2024 22:06:02 +0000 Original-Received: (at 73355) by debbugs.gnu.org; 21 Sep 2024 22:05:26 +0000 Original-Received: from localhost ([127.0.0.1]:40423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss8EH-0002nz-PZ for submit@debbugs.gnu.org; Sat, 21 Sep 2024 18:05:26 -0400 Original-Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]:37891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ss8EG-0002lP-3A for 73355@debbugs.gnu.org; Sat, 21 Sep 2024 18:05:24 -0400 Original-Received: from phl-compute-01.internal (phl-compute-01.phl.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id 21A171140143; Sat, 21 Sep 2024 18:04:57 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-01.internal (MEProxy); Sat, 21 Sep 2024 18:04:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1726956297; x=1727042697; bh=2xqXoYv39FBydBggSrEOklOfgtZIGDQajTXEYu/+KrM=; b= IGPsg33LMGyevYl7MQpg5KKNelbSK7HgREazyNUwbIj1Q23nFEOpJ3L5SV9DR4EU NOWbRbFIh+Y0n/lNUC3uZTTWJVyrr6ldg9BlQGh+SaYdMo90itISQF8vgfh6P1vm XDDvBa/Nn2ueIAHCcMJSkJs/rW8dpmgmthjB0ru3Bhd261Id1aIlTV8sSjDDD3j9 R4YMTGXqkTFks0cW2D/CR2SdairL1fQV8nN6gJGGPNfF7lyjZOLGnmpO4G/xmpvn ZaCOyCY0OqWW3nReWME0H60RASCo6iAh0w1PWxJfPqcuEnToEvh/00xvlfxVnAnI e6dk7rXHDfuNdU1+WwO8Sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1726956297; x= 1727042697; bh=2xqXoYv39FBydBggSrEOklOfgtZIGDQajTXEYu/+KrM=; b=H MsJn2G6mGu/9jC0AtnMyaUmUU/5kuDtTJ2PvbPfqPsPB6uRBe360o35yYHk38/hr IFYjJ7JHXO1cXTFRbGMT7qA7slElMG1qRqPkEtApefD/5qco3+tAp0wr8xlUEBSu KzqknwxpTNiVkO/kO5nbKb21NSNhZkD6zBw3jNSE0bjwkw1zpqeRHtZuyJ5QWA8O W8iVG5/RBBCio7br8WKye+9m9g2Ub4LxljZY5IB7VLasB5CrYo/EDlgX7isY1D15 4giYlj9DCRapXmGT1n/sGKzzFzhZ+nb2BcahertpsbYxQn+XPDGWqNs/B5vHmMfJ 2N+yizgMdDTxCUkC+KLbg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeliedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvvefujghffffkgggtgfesthhqredttddtjeen ucfhrhhomheplfhoohhsthcumfhrvghmvghrshcuoehjohhoshhtkhhrvghmvghrshesfh grshhtmhgrihhlrdhfmheqnecuggftrfgrthhtvghrnhepgffggeekheevfefgtdfgveej feegveehfeelueehgfehgeejheevjeeugfejjedtnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoohhsthhkrhgvmhgvrhhssehfrghsthhm rghilhdrfhhmpdhnsggprhgtphhtthhopeefpdhmohguvgepshhmthhpohhuthdprhgtph htthhopeejfeefheehseguvggssghughhsrdhgnhhurdhorhhgpdhrtghpthhtohepvghl ihiisehgnhhurdhorhhgpdhrtghpthhtohepjhhorghothgrvhhorhgrsehgmhgrihhlrd gtohhm X-ME-Proxy: Feedback-ID: ie15541ac:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 21 Sep 2024 18:04:55 -0400 (EDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 21 Sep 2024 21:15:42 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292210 Archived-At: On Sat, Sep 21 2024, Jo=C3=A3o T=C3=A1vora wrote: > On Sat, Sep 21, 2024, 13:13 Joost Kremers > wrote:. > >> >> > It's possible Eglot is just successfully applying 0 edits. >> >> I guess that's one way of looking at it. :-) >> > > I'm say this because Eglot has no logic to check if a rename is valid or > not. It just does what the server tells it to. If the intended rename is > invalid, the server can error out (and Eglot will tell you this) out retu= rn > 0 edits. Either way, the server calls all the shots. Ah, OK, I didn't realise that. So does the server report it made 0 edits? If it does, would it make sense to have Eglot say no changes were made? As soon as I have some time, I'll see if I can find out a bit more and possibly take it up with the basedpyright people. Thanks, Joost --=20 Joost Kremers Life has its moments