From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54154: Emacs commit ae963e80a79f5a9184daabfc8197f211a39b136d (sieve-manage) Date: Sun, 29 Sep 2024 13:23:03 +0300 Message-ID: <86plom4v3s.fsf@gnu.org> References: <874jsngod2.fsf@tetzco.de> <83tu0nynla.fsf@gnu.org> <873586d7ii.fsf@tetzco.de> <834jsmpqf9.fsf@gnu.org> <87bkmua51z.fsf@tetzco.de> <83v8l2o212.fsf@gnu.org> <878rhut6aq.fsf@tetzco.de> <87ilgxs8vl.fsf@tetzco.de> <878rhts69s.fsf@tetzco.de> <87pmb5qiwv.fsf@tetzco.de> <87bkmpf87t.fsf@igel.home> <87o74696he.wl-herbert@gojira.at> <86seti4xks.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28560"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de To: herbert@gojira.at Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 29 12:23:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sur5l-0007Kq-9W for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Sep 2024 12:23:53 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sur5R-0006fW-Jp; Sun, 29 Sep 2024 06:23:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sur5P-0006fG-UU for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 06:23:32 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sur5P-0000i9-KU for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 06:23:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=96JT67m/bMmyzvN8ozfgyMeTDky1ap+KULVTBEF+ydY=; b=i7BIfOAg+Z4BvMxH7gBJTOqEmfefKNIYdrRHz1/cMI5AGdqCJ14FUjpAPa3JERHZKpSRPECjFdrdgCqrMigd34LhYPrT5LIzZBZSdiroCET0VHkj6JrBPzJLcDTjIhUDrC0mX33FgCl1OIM3GOe9S03u174sNTK4kUZ3zncz/q0qA5dE7piQ2fmSI1w34pKZplc4FubxSDcH4HeBX7dtxdxY+YZ96kiUyAqEwj2TYMIpdTEu9zcfny+zNHpcYr1Mbw8jRVNMd86de3SkvoyKddS6LYFO7M9+mrqtzZWEkVSmDitOREdt+rC3vGDjr/NZQ8sDlcTkw8ZXdjyc6lJlWg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sur5u-0007LO-GX for bug-gnu-emacs@gnu.org; Sun, 29 Sep 2024 06:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Sep 2024 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54154 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54154-submit@debbugs.gnu.org id=B54154.172760543328204 (code B ref 54154); Sun, 29 Sep 2024 10:24:02 +0000 Original-Received: (at 54154) by debbugs.gnu.org; 29 Sep 2024 10:23:53 +0000 Original-Received: from localhost ([127.0.0.1]:40139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sur5i-0007KN-DB for submit@debbugs.gnu.org; Sun, 29 Sep 2024 06:23:53 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sur5c-0007IY-RO for 54154@debbugs.gnu.org; Sun, 29 Sep 2024 06:23:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sur4z-0000fP-TC; Sun, 29 Sep 2024 06:23:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=96JT67m/bMmyzvN8ozfgyMeTDky1ap+KULVTBEF+ydY=; b=j9h1X2QY7dNl ukiwuoI/wOabZSXVHfx4gtVe1gP3DLjquoU0o16UxotWd2aiCIBEgRQYRHlfGvcNE5t2IZdNuo+ga lGkH+B2dKKdnYc01ok+uvu9o6mkW4D7FtIsqy9Z+0Zl6T91uNQTrex8luwJwpepen9ouIvUu3gJx+ KG4y5yxXSpFryFEwFld690ioEMCoWQ3qqvFzHdvKkRbcazC5a9Ki1UmCi4a8VsocxWHXJ+ugdkPmF yasleBTVvIIdgoPWS43RClg7gPTxpflAkbSk+mIqAc12sgR8uUaRj8RZAOZSnXWZZ2gjbEZM5kbH3 EXd6qO76y7yGmIbZDndrug==; In-Reply-To: <86seti4xks.fsf@gnu.org> (message from Eli Zaretskii on Sun, 29 Sep 2024 12:29:39 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292625 Archived-At: > Cc: larsi@gnus.org, 54154@debbugs.gnu.org, emacs+bug@tetzco.de > Date: Sun, 29 Sep 2024 12:29:39 +0300 > From: Eli Zaretskii > > > - Run emacs -Q > > - M-x sieve-manage > > - Input IMAP server (e.g. imap.mailbox.org) > > > > Debugger entered--Lisp error: (wrong-type-argument stringp t) > > sieve-manage--append-to-log("sieve-manage: Connecting to imap.mailbox.org..." "\n") > > sieve-manage--message("Connecting to %s..." "imap.mailbox.org") > > sieve-manage-open("imap.mailbox.org" nil) > > sieve-open-server("imap.mailbox.org" nil) > > sieve-manage("imap.mailbox.org") > > funcall-interactively(sieve-manage "imap.mailbox.org") > > command-execute(sieve-manage record) > > execute-extended-command(nil "sieve-manage" "sieve-ma") > > funcall-interactively(execute-extended-command nil "sieve-manage" "sieve-ma") > > command-execute(execute-extended-command) > > > > On 2nd try it works! > > The fix was not merged to the-then master branch, so it is not in > Emacs 30. Therefore, it is not a surprise you still see the problem: > it was only fixed in Emacs 29. > > I lost the context long ago, so I hope Kai will suggest how to handle > this. However, it's quite possible that the following band-aid should fix this particular issue: diff --git a/lisp/net/sieve-manage.el b/lisp/net/sieve-manage.el index 0faeb02..da2167c 100644 --- a/lisp/net/sieve-manage.el +++ b/lisp/net/sieve-manage.el @@ -178,7 +178,8 @@ sieve-manage--append-to-log (with-current-buffer (get-buffer-create sieve-manage-log) (set-buffer-multibyte nil) - (buffer-disable-undo))) + (buffer-disable-undo) + (current-buffer))) (goto-char (point-max)) (apply #'insert args)))) Can you test this?