From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: "Final" version of tty child frames
Date: Tue, 22 Oct 2024 12:42:56 +0300
Message-ID: <86plnsfp7j.fsf@gnu.org>
References: <m2h694lp7s.fsf@gmail.com> <86ttd4ftvs.fsf@gnu.org>
 <m2cyjsim3s.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="32362"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Gerd =?utf-8?Q?M=C3=B6llmann?= <gerd.moellmann@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 22 11:44:22 2024
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1t3BR8-0008KT-0V
	for ged-emacs-devel@m.gmane-mx.org; Tue, 22 Oct 2024 11:44:22 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces@gnu.org>)
	id 1t3BPw-00057c-OP; Tue, 22 Oct 2024 05:43:08 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1t3BPp-0004hI-UZ
 for emacs-devel@gnu.org; Tue, 22 Oct 2024 05:43:02 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1t3BPp-0001Dz-MA; Tue, 22 Oct 2024 05:43:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=CBL8BCcqYz/KgTpsGxbcVNrpQa3OOzxCzwMqwx7FDoI=; b=cNuGVOlfz/H1OSJklWBR
 rtsTcXvuFNTIjJXegFhnJG4eAvVrkFhdZaE2IY3htWzljCJzixQo5Rldc/W2XY/MHzYBk4TGumSrk
 F47HlIBrdrcYY+Xux55DQqIFkto+ccZJEikdIOJhD5wdjl1LBvICMc+ZwF+Kde7xQi5mmUsAOH77+
 Ax87XVvZJ6GZjuAFtmUvRMIoUy7zQp1INE9XELqLiT7Bod3X9odao7KUY3g2Rcm47t6YU3GyHz6uD
 yb2686vU4GE//8b3QiyHWfzcD/vc60uvAcChs08ZYQdNhI1lEA/Z63MtMBB15A0Tr63EW3ZYvI+9Q
 SrnH80l7lCwS5A==;
In-Reply-To: <m2cyjsim3s.fsf@gmail.com> (message from Gerd =?utf-8?Q?M?=
 =?utf-8?Q?=C3=B6llmann?= on Tue, 22 Oct 2024 10:21:43 +0200)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.devel:324725
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/324725>

> From: Gerd Möllmann <gerd.moellmann@gmail.com>
> Cc: emacs-devel@gnu.org
> Date: Tue, 22 Oct 2024 10:21:43 +0200
> 
> Thanks for taking a look.

Can you explain this comment and the code change:

  +         /* Struct frame can move with igc, and so on.  But we need
  +            something that takes different frames into account. Use the
  +            face_cache pointer for that which is malloc'd. */
  +         if (glyph->frame && glyph->frame != f)
  +           face_id += (ptrdiff_t) glyph->frame->face_cache;

Why do we need to take the frame into account here?  Is this relevant
to the current GC used on master?