From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#74104: 31.0.50; 'custom-set-faces' overrides face when no theme is loaded Date: Wed, 30 Oct 2024 17:39:30 +0200 Message-ID: <86plnh4n2l.fsf@gnu.org> References: <87y125ucbz.fsf@protesilaos.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 74104@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 30 16:40:25 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t6Ao4-00030A-Re for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Oct 2024 16:40:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t6Ann-0008W4-2Z; Wed, 30 Oct 2024 11:40:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6Ank-0008Vu-Ek for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2024 11:40:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t6Ani-0004Km-J0 for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2024 11:40:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=References:In-Reply-To:From:Date:To:Subject; bh=dN3lMUQujEZU+aeN1pAZlV5v7RqOQCbZI5KFyt49b6c=; b=p2vCFobnwHcGOJAoVk9VQeO0VpK3f2/EG6DDFG1o51X/rrbsnFLihrjRXrtjzu25hmlDB7TV8xt4g0/NyU+AN0rA5beG2wM4bL4BOoUO8lkjKpyr7+uHhgjgO7MMnKlwJqNYc+8TuTG7KdrTc3YyY9nATzGmk9+fq1wM79r1c67itPIjdUxa8QuN6JjvvmfRvlcjCD1l9/NBAWpdq9+V05Q+qHzC7yr03fC4XODeJHbX1iJQV0nz/qvoh7Dwy2ToYfN5EivaTVomA3udY9qMC7n50rimjpXjQQvNrBf4Mqx7w2iNJtC6EZaXxzW3QPW2juOeAMUOAdz4mIsDFgOtsg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t6Ani-0006J7-EM for bug-gnu-emacs@gnu.org; Wed, 30 Oct 2024 11:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Oct 2024 15:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74104 X-GNU-PR-Package: emacs Original-Received: via spool by 74104-submit@debbugs.gnu.org id=B74104.173030278224225 (code B ref 74104); Wed, 30 Oct 2024 15:40:02 +0000 Original-Received: (at 74104) by debbugs.gnu.org; 30 Oct 2024 15:39:42 +0000 Original-Received: from localhost ([127.0.0.1]:35737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6AnN-0006Ie-Ss for submit@debbugs.gnu.org; Wed, 30 Oct 2024 11:39:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t6AnL-0006IS-MO for 74104@debbugs.gnu.org; Wed, 30 Oct 2024 11:39:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t6AnF-0004Gb-UW; Wed, 30 Oct 2024 11:39:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dN3lMUQujEZU+aeN1pAZlV5v7RqOQCbZI5KFyt49b6c=; b=aH7U+kpIWF0G xaopEbSFHn279cTB+hMIpPUdeK9oA7iR/LJKz4NiKqmvkJqoedQYTu3VVwjB43xxG8RPVO7tQ18rJ dIUdnnHd5rw+MxTFW+Dnx7RdvCAf9dt5qFwX/leWwjgDw8R8YAl3Ox/E0i+yM4KrqqgMENdR+BKAk sVK2bpmjOXZEfM+AvHGsTRfG8q6znap1Tnlml/bn/fB1YtD4TSWiLudoiUXUjEeintNCY0ynxqOz3 u7Eg4nVqNvXDtw+2jOUw2WWzXu0rq+npmAy8QaxAz4D3XyRE53nnjZn8g0AX++6VgD6wC1uBPnroL pJuT+5ccko5XH3yaK5kl4A==; In-Reply-To: <87y125ucbz.fsf@protesilaos.com> (message from Protesilaos Stavrou on Wed, 30 Oct 2024 12:14:40 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294566 Archived-At: > From: Protesilaos Stavrou > Date: Wed, 30 Oct 2024 12:14:40 +0200 > > Dear maintainers, > > When a theme is already enabled, 'custom-set-faces' has the effect of > adding face attributes on top of the existing ones. Those that were > present are not removed: they are blended with the new ones. > > This, however, is not happening when no theme is loaded. In that > scenario, 'custom-set-faces' removes all the underlying face attributes > and keeps only those specified in the function call. I think this is a > mistake. custom-set-faces is used to set up customized faces in the user's init files: they are the forms written by Custom when the user decides to save the face customizations for future sessions. So I don't think this is a mistake, and I don't see how we can change this without catastrophic effects on everyone's init files.