From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel@gnu.org, p.d.oliver@mavit.org.uk,
bjorn.bidar@thaodan.de, stefankangas@gmail.com,
pedz@easesoftware.com, pedz@easesoftware.com,
jostein@secure.kjonigsen.net, theo@thornhill.no,
v.pupillo@gmail.com, dev@rjt.dev, wkirschbaum@gmail.com,
jm@pub.pink, dgutov@yandex.ru, jm@pub.pink, juri@linkov.net
Subject: Re: Validating tree-sitter major modes and grammar
Date: Tue, 24 Dec 2024 14:19:59 +0200 [thread overview]
Message-ID: <86pllh2ryo.fsf@gnu.org> (raw)
In-Reply-To: <D7386064-DBA3-4E28-9DDD-84BCD3B4F3D1@gmail.com> (message from Yuan Fu on Mon, 23 Dec 2024 19:12:18 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 23 Dec 2024 19:12:18 -0800
> Cc: Peter Oliver <p.d.oliver@mavit.org.uk>,
> Björn Bidar <bjorn.bidar@thaodan.de>,
> Stefan Kangas <stefankangas@gmail.com>,
> Perry Smith <pedz@easesoftware.com>, Perry Smith <pedz@easesoftware.com>,
> Jostein Kjønigsen <jostein@secure.kjonigsen.net>,
> Theodor Thornhill <theo@thornhill.no>,
> Vincenzo Pupillo <v.pupillo@gmail.com>, Randy Taylor <dev@rjt.dev>,
> Wilhelm Kirschbaum <wkirschbaum@gmail.com>, john muhl <jm@pub.pink>,
> Dmitry Gutov <dgutov@yandex.ru>, john muhl <jm@pub.pink>,
> Juri Linkov <juri@linkov.net>
>
>
>
> > On Dec 20, 2024, at 1:09 AM, Yuan Fu <casouri@gmail.com> wrote:
> >
> > Continuing from the tree-sitter maternity thread, I cooked up some script to go over each builtin tree-sitter mode, clone the grammars it uses, and check whether the font-lock queries are compatible with the latest version of the grammar. If everything works fine, the script adds some comment in the source file listing the version that was checked.
> >
> > For example, I ran the script for c-ts-mode and c++-ts-mode, and this is the comment inserted to c-ts-mode.el:
> >
> > ;;; Tree-sitter language versions
> > ;;
> > ;; c-ts-mode is known to work with the following languages and version:
> > ;; - tree-sitter-c: v0.23.4
> > ;;
> > ;; c++-ts-mode is known to work with the following languages and version:
> > ;; - tree-sitter-cpp: v0.23.4-1-gf41b4f6
> > ;;
> > ;; We try our best to make builtin modes work with latest grammar
> > ;; versions, so a more recent grammar version has a good chance to work.
> > ;; Send us a bug report if it doesn't.
> >
> > The version is taken from “git describe”. If the grammar isn’t versioned, it’ll just be the hash of HEAD. In order for “git describe” to work, I had to do full clones, and some tree-sitter grammar’s repo is very slow to clone. I wonder if there’s anything we can do to speed it up?
> >
> > Any thoughts/comments? I pushed the code to master so others can play with it.
> >
> > BTW, the script revealed that cmake-ts-mode isn’t compatible with the latest grammar. I’ll try fix it later.
>
> (This is now fixed.)
>
>
>
> CC’ing maintainers for builtin modes for comments. Also, Eli, what’s your thoughts on this after the clarification?
Sorry, I thought we had this discussion concluded and closed. What
are the issues that still need decisions?
next prev parent reply other threads:[~2024-12-24 12:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-20 9:09 Validating tree-sitter major modes and grammar Yuan Fu
2024-12-20 12:24 ` Eli Zaretskii
2024-12-20 16:22 ` Yuan Fu
2024-12-23 0:44 ` Björn Bidar
[not found] ` <868qs6vd76.fsf@aarsen.me>
2024-12-24 1:16 ` Yuan Fu
2024-12-24 3:12 ` Yuan Fu
2024-12-24 12:19 ` Eli Zaretskii [this message]
2024-12-24 21:30 ` Yuan Fu
2024-12-24 23:09 ` Dmitry Gutov
2024-12-25 8:39 ` Yuan Fu
[not found] ` <6768b29d.050a0220.1b40f2.5574SMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-24 3:20 ` Yuan Fu
2024-12-24 12:36 ` Peter Oliver
2024-12-24 14:20 ` Michael Albinus
2024-12-24 22:20 ` Yuan Fu
2024-12-25 8:20 ` Michael Albinus
2024-12-25 9:33 ` Yuan Fu
2024-12-24 22:14 ` Yuan Fu
2024-12-24 21:36 ` Björn Bidar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86pllh2ryo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=bjorn.bidar@thaodan.de \
--cc=casouri@gmail.com \
--cc=dev@rjt.dev \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=jm@pub.pink \
--cc=jostein@secure.kjonigsen.net \
--cc=juri@linkov.net \
--cc=p.d.oliver@mavit.org.uk \
--cc=pedz@easesoftware.com \
--cc=stefankangas@gmail.com \
--cc=theo@thornhill.no \
--cc=v.pupillo@gmail.com \
--cc=wkirschbaum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.