From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: VC commit missing ChangeLog message Date: Tue, 11 Nov 2008 15:38:22 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <86od0mgcz5.fsf@lifelogs.com> References: <86ej1il3z7.fsf@lifelogs.com> <1226414985.525611.2969.nullmailer@null> <8663mukybp.fsf@lifelogs.com> <200811111658.mABGwYR1004191@mothra.ics.uci.edu> <86myg6hycx.fsf@lifelogs.com> <200811111945.mABJjWvA004946@mothra.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1226439675 22356 80.91.229.12 (11 Nov 2008 21:41:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Nov 2008 21:41:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 11 22:42:16 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1L00zs-00077d-Ha for ged-emacs-devel@m.gmane.org; Tue, 11 Nov 2008 22:42:04 +0100 Original-Received: from localhost ([127.0.0.1]:35864 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L00yk-0006gY-Hu for ged-emacs-devel@m.gmane.org; Tue, 11 Nov 2008 16:40:54 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L00x2-0005yY-3P for emacs-devel@gnu.org; Tue, 11 Nov 2008 16:39:08 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L00wz-0005xL-Qk for emacs-devel@gnu.org; Tue, 11 Nov 2008 16:39:07 -0500 Original-Received: from [199.232.76.173] (port=59573 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L00wz-0005xC-Gk for emacs-devel@gnu.org; Tue, 11 Nov 2008 16:39:05 -0500 Original-Received: from main.gmane.org ([80.91.229.2]:52684 helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L00wy-0002Kl-HC for emacs-devel@gnu.org; Tue, 11 Nov 2008 16:39:05 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1L00wS-0007lQ-5g for emacs-devel@gnu.org; Tue, 11 Nov 2008 21:38:32 +0000 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Nov 2008 21:38:32 +0000 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 11 Nov 2008 21:38:32 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 40 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:kQ7ccV4GJMc+cF/CWHkwEN3333U= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:105584 Archived-At: On Tue, 11 Nov 2008 11:45:32 -0800 (PST) Dan Nicolaescu wrote: DN> Ted Zlatanov writes: >> On Tue, 11 Nov 2008 08:58:34 -0800 (PST) Dan Nicolaescu wrote: DN> It could and it should, just nobody has done the work yet to do it... DN> If you are interested, it can be done `vc-checkin' by initializing the DN> `initial-contents' parameter before the call to `vc-start-log-entry'. >> >> Wouldn't it be easier to do it by calling the function directly? DN> Not sure what your question is... What I described is one way to DN> initialize the contents of the *VC-log* buffer. There's a function that will do it (`C-c C-a' == log-edit-insert-changelog), I'm trying to find out if it's easier to always call that function when setting up the *VC-log* buffer than use initial-contents as you suggested. It seems so to me, and Stefan suggested it too. Incidentally, there are two functions named log-edit-changelog-insert-entries and log-edit-insert-changelog-entries. I think one of the two should be renamed to avoid confusion. >> Or do you mean I can insert the commented lines I suggested as well >> that way? DN> If you add those comments, you'd need to add some post-processing to DN> make sure they get removed before checking in, so it might not be the DN> best idea. It's for user convenience, so I think it's a good idea. It's just modifying log-edit-done at the beginning--it already does removal of trailing empty lines, so this is pretty easy. Simply go to point-min and then remove all the lines that match "^;;;". I can write and test it unless you or someone else think it's a problem. Thanks Ted