* bug#19387: SVN VC backend is unbearably slow on larger repositories
@ 2014-12-15 15:14 Paul Pogonyshev
2014-12-15 15:45 ` Dmitry Gutov
2014-12-18 13:50 ` Dmitry Gutov
0 siblings, 2 replies; 4+ messages in thread
From: Paul Pogonyshev @ 2014-12-15 15:14 UTC (permalink / raw)
To: 19387
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
When I 'C-x v d' my working directory in a recent Emacs, it prints
"Traversing directory: ..." and goes through the whole repository. I have
no idea what it looks for. After about 1 minute of waiting I C-g'd it.
It used to work instantly (well, in under 2 seconds anyway) a couple of
weeks ago; don't remember more precisely.
Version: GNU Emacs 25.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version
3.10.9) of 2014-12-15
Paul
[-- Attachment #2: Type: text/html, Size: 517 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#19387: SVN VC backend is unbearably slow on larger repositories
2014-12-15 15:14 bug#19387: SVN VC backend is unbearably slow on larger repositories Paul Pogonyshev
@ 2014-12-15 15:45 ` Dmitry Gutov
2014-12-18 13:50 ` Dmitry Gutov
1 sibling, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2014-12-15 15:45 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: 19387
Paul Pogonyshev <pogonyshev@gmail.com> writes:
> When I 'C-x v d' my working directory in a recent Emacs, it prints
> "Traversing directory: ..." and goes through the whole repository. I have
> no idea what it looks for. After about 1 minute of waiting I C-g'd it.
>
> It used to work instantly (well, in under 2 seconds anyway) a couple of
> weeks ago; don't remember more precisely.
I can confirm this. The culprit is b1a765b3. We should probably revert
the essence of the change, as well as reinstate the FIXME (the meaning
of which is not exactly clear to me).
diff --git a/lisp/vc/vc-svn.el b/lisp/vc/vc-svn.el
index eedccd8..3f977e0 100644
--- a/lisp/vc/vc-svn.el
+++ b/lisp/vc/vc-svn.el
@@ -202,11 +202,11 @@ If you want to force an empty list of arguments, use t."
(autoload 'vc-expand-dirs "vc")
-(defun vc-svn-dir-status-files (dir files callback)
+(defun vc-svn-dir-status-files (_dir files callback)
"Run 'svn status' for DIR and update BUFFER via CALLBACK.
CALLBACK is called as (CALLBACK RESULT BUFFER), where
RESULT is a list of conses (FILE . STATE) for directory DIR."
- (if (not files) (setq files (vc-expand-dirs (list dir) 'SVN)))
+ ;; FIXME shouldn't this rather default to all the files in dir?
(vc-svn-command (current-buffer) 'async nil "status" "-u" files)
(vc-run-delayed (vc-svn-after-dir-status callback)))
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#19387: SVN VC backend is unbearably slow on larger repositories
2014-12-15 15:14 bug#19387: SVN VC backend is unbearably slow on larger repositories Paul Pogonyshev
2014-12-15 15:45 ` Dmitry Gutov
@ 2014-12-18 13:50 ` Dmitry Gutov
2014-12-22 10:48 ` Paul Pogonyshev
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Gutov @ 2014-12-18 13:50 UTC (permalink / raw)
To: Paul Pogonyshev; +Cc: 19387-done
Paul Pogonyshev <pogonyshev@gmail.com> writes:
> When I 'C-x v d' my working directory in a recent Emacs, it prints
> "Traversing directory: ..." and goes through the whole repository. I have
> no idea what it looks for. After about 1 minute of waiting I C-g'd it.
The patch has been applied. The feature seems to work now, but please
double-check.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-22 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-15 15:14 bug#19387: SVN VC backend is unbearably slow on larger repositories Paul Pogonyshev
2014-12-15 15:45 ` Dmitry Gutov
2014-12-18 13:50 ` Dmitry Gutov
2014-12-22 10:48 ` Paul Pogonyshev
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.