From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: Crash at startup in Cygwin w32 build on emacs-25 branch Date: Fri, 27 Nov 2015 23:44:55 +0000 Message-ID: <86oaef2eiw.fsf@gmail.com> References: <86bnagfgf7.fsf@gmail.com> <83d1uvuawp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1448667925 14404 80.91.229.3 (27 Nov 2015 23:45:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 23:45:25 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 28 00:45:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a2ShW-0006tt-EY for ged-emacs-devel@m.gmane.org; Sat, 28 Nov 2015 00:45:14 +0100 Original-Received: from localhost ([::1]:58944 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2ShZ-0005My-9J for ged-emacs-devel@m.gmane.org; Fri, 27 Nov 2015 18:45:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44462) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2ShW-0005Mq-Hi for emacs-devel@gnu.org; Fri, 27 Nov 2015 18:45:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a2ShT-0003N9-91 for emacs-devel@gnu.org; Fri, 27 Nov 2015 18:45:14 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:38732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a2ShT-0003N3-1m for emacs-devel@gnu.org; Fri, 27 Nov 2015 18:45:11 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1a2ShM-0006WN-DE for emacs-devel@gnu.org; Sat, 28 Nov 2015 00:45:04 +0100 Original-Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 28 Nov 2015 00:45:04 +0100 Original-Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 28 Nov 2015 00:45:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (windows-nt) Cancel-Lock: sha1:9MbUt5YJFcrngiqyjiPClk0xmQQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:195422 Archived-At: On Fri 27 Nov 2015, Eli Zaretskii wrote: >> From: Andy Moreton >> Date: Fri, 27 Nov 2015 00:13:16 +0000 >> Cc: Eli Zaretskii >> >> The changes in commit d696d62fea48 cause an instant crash at startup for >> the cygwin w32 build, as the main Windows thread ID is not initialized. > > Thanks, fixed. (I couldn't imagine Cygwin needs the thread > information.) Only the Cygwin w32 build, which sets HAVE_NTGUI and uses the Windows GUI code for display (so no need for an X11 server). The module code also uses dwMainThreadId for error checking, and may need similar changes for the Cygwin w32 build. It may be safer to provide the thread ID from a function to ensure that it has been initialised before callers try to use it. > Btw, it's high time you got write access to the repository. Would you > like that? That would prbably make sense. What needs to be done to arrange that ? AndyM