From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.devel Subject: Re: bignum branch Date: Sun, 05 Aug 2018 11:46:17 +0100 Message-ID: <86o9eh9jly.fsf@gmail.com> References: <87o9fbbw1t.fsf@tromey.com> <86in5jdj49.fsf@gmail.com> <83wotxaiwi.fsf@gnu.org> <86k1pxmvmx.fsf@gmail.com> <87efg4a9xc.fsf@tromey.com> <87a7qr8cz7.fsf@tromey.com> <86tvoy3je9.fsf@gmail.com> <86bmb0vbxf.fsf@gmail.com> <87k1pnfcg1.fsf@tromey.com> <86sh4b1833.fsf@gmail.com> <861sbgz3dm.fsf@gmail.com> <87ftzum6ge.fsf@tromey.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1533465949 10479 195.159.176.226 (5 Aug 2018 10:45:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 5 Aug 2018 10:45:49 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (windows-nt) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Aug 05 12:45:45 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fmGXh-0002dL-4e for ged-emacs-devel@m.gmane.org; Sun, 05 Aug 2018 12:45:45 +0200 Original-Received: from localhost ([::1]:58104 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmGZn-0005Fx-Rq for ged-emacs-devel@m.gmane.org; Sun, 05 Aug 2018 06:47:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fmGYX-0005Fg-G3 for emacs-devel@gnu.org; Sun, 05 Aug 2018 06:46:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fmGYT-0001i3-FB for emacs-devel@gnu.org; Sun, 05 Aug 2018 06:46:37 -0400 Original-Received: from [195.159.176.226] (port=41383 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fmGYT-0001gA-78 for emacs-devel@gnu.org; Sun, 05 Aug 2018 06:46:33 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1fmGWH-000165-KY for emacs-devel@gnu.org; Sun, 05 Aug 2018 12:44:17 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 47 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:Ox9YEe23bhBDr1VmZTExzY/X1yk= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228186 Archived-At: On Sat 04 Aug 2018, Tom Tromey wrote: >>>>>> "Andy" == Andy Moreton writes: > > Andy> The patch has been tested with the attached ccl-tests.el ERT tests to > Andy> check that ash/lsh shifts behave properly, and that the CCL machinery > Andy> uses its 28bit codewords correctly in a bignum build. > > Andy> Please check this works for you, and feel free to commit it to the > Andy> bignum branch. > > I've applied the patch but the new test fails for me. > I've appended the log. The test failure is caused by a missing space in the expected CCL dump output. The following (add a single space) works for me: diff --git a/test/lisp/international/ccl-tests.el b/test/lisp/international/ccl-tests.el index d0c254ce91..ba6d2040e8 100644 --- a/test/lisp/international/ccl-tests.el +++ b/test/lisp/international/ccl-tests.el @@ -162,7 +162,7 @@ prog-midi-dump Main-body: 2:[read-jump-cond-expr-const] read r0, if !(r0 < 128), jump to 22(+20) 5:[branch] jump to array[r3] of length 4 - 11 12 15 18 22 + 11 12 15 18 22 11:[jump] jump to 2(-9) 12:[set-register] r1 = r0 13:[set-register] r0 = r4 > I fixed a couple of trivial formatting issues in your patch, and I also > added a comment by ccl-fixnum, but otherwise it's what you wrote. Thanks. I was going to add the explanation I gave to Eli earlier in this thread: ;; The CCL compiled codewords are 28bits, but the CCL implementation ;; assumes that the codewords are sign-extended, so that data constants in ;; the upper part of the codeword are signed. This function truncates a ;; codeword to 28bits, and then sign extends the result to a fixnum. Perhaps you could add that to give a more detailed explanation. Hopefully nobody else will need to do anything further to CCL until it is deprecated and removed. :-) AndyM