From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stephen Leake Newsgroups: gmane.emacs.devel Subject: Re: display-buffer-use-some-frame Date: Sun, 23 Dec 2018 10:23:54 -0800 Message-ID: <86o99c2jb9.fsf@stephe-leake.org> References: <5BD601F9.2010708@gmx.at> <8636r3g8s8.fsf@stephe-leake.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1545589355 22081 195.159.176.226 (23 Dec 2018 18:22:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 23 Dec 2018 18:22:35 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (windows-nt) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 23 19:22:31 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gb8OS-0005bT-K1 for ged-emacs-devel@m.gmane.org; Sun, 23 Dec 2018 19:22:28 +0100 Original-Received: from localhost ([::1]:41779 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gb8QZ-0000C5-CY for ged-emacs-devel@m.gmane.org; Sun, 23 Dec 2018 13:24:39 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gb8Py-0000Bm-JV for emacs-devel@gnu.org; Sun, 23 Dec 2018 13:24:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gb8Pv-0003fK-PA for emacs-devel@gnu.org; Sun, 23 Dec 2018 13:24:02 -0500 Original-Received: from smtp113.iad3b.emailsrvr.com ([146.20.161.113]:42517) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gb8Pv-0003Tc-LG for emacs-devel@gnu.org; Sun, 23 Dec 2018 13:23:59 -0500 Original-Received: from smtp7.relay.iad3b.emailsrvr.com (localhost [127.0.0.1]) by smtp7.relay.iad3b.emailsrvr.com (SMTP Server) with ESMTP id B80176041F for ; Sun, 23 Dec 2018 13:23:55 -0500 (EST) X-Auth-ID: board-president@tomahawk-creek-hoa.com Original-Received: by smtp7.relay.iad3b.emailsrvr.com (Authenticated sender: board-president-AT-tomahawk-creek-hoa.com) with ESMTPSA id 65498603B8 for ; Sun, 23 Dec 2018 13:23:55 -0500 (EST) X-Sender-Id: board-president@tomahawk-creek-hoa.com Original-Received: from Takver4 ([UNAVAILABLE]. [76.77.182.20]) (using TLSv1.2 with cipher AES256-GCM-SHA384) by 0.0.0.0:25 (trex/5.7.12); Sun, 23 Dec 2018 13:23:55 -0500 In-Reply-To: <8636r3g8s8.fsf@stephe-leake.org> (Stephen Leake's message of "Tue, 11 Dec 2018 11:31:19 -0800") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 146.20.161.113 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:231969 Archived-At: Stephen Leake writes: > martin rudalics writes: > >> - In the call >> >> (window--display-buffer >> buffer window 'frame alist display-buffer-mark-dedicated) >> >> you should write 'reuse instead of 'frame. The latter means that a >> new frame has been made but you just reuse an existing window. I >> noticed this because I made the same error in (an undocumented part >> of) 'display-buffer-in-child-frame'. > > I'll fix this after the test below. Committed in emacs-26 >> Also, I wonder why you call >> 'frame-first-window' here: >> >> (not (window-dedicated-p >> (or >> (get-lru-window frame) >> (frame-first-window frame))))) > > I don't remember. I'll test for a while without it. No problems with the testing. get-lru-window never returns a dedicated window, so this can be simplified to: (let* ((predicate (or (cdr (assq 'frame-predicate alist)) (lambda (frame) (and (not (eq frame (selected-frame))) (get-lru-window frame))))) Committed in emacs-26 -- -- Stephe