From: Stephen Leake <stephen_leake@stephe-leake.org>
To: emacs-devel <emacs-devel@gnu.org>
Subject: Re: display-buffer-use-some-frame
Date: Sun, 23 Dec 2018 10:23:54 -0800 [thread overview]
Message-ID: <86o99c2jb9.fsf@stephe-leake.org> (raw)
In-Reply-To: <8636r3g8s8.fsf@stephe-leake.org> (Stephen Leake's message of "Tue, 11 Dec 2018 11:31:19 -0800")
Stephen Leake <stephen_leake@stephe-leake.org> writes:
> martin rudalics <rudalics@gmx.at> writes:
>
>> - In the call
>>
>> (window--display-buffer
>> buffer window 'frame alist display-buffer-mark-dedicated)
>>
>> you should write 'reuse instead of 'frame. The latter means that a
>> new frame has been made but you just reuse an existing window. I
>> noticed this because I made the same error in (an undocumented part
>> of) 'display-buffer-in-child-frame'.
>
> I'll fix this after the test below.
Committed in emacs-26
>> Also, I wonder why you call
>> 'frame-first-window' here:
>>
>> (not (window-dedicated-p
>> (or
>> (get-lru-window frame)
>> (frame-first-window frame)))))
>
> I don't remember. I'll test for a while without it.
No problems with the testing. get-lru-window never returns a dedicated
window, so this can be simplified to:
(let* ((predicate
(or (cdr (assq 'frame-predicate alist))
(lambda (frame)
(and (not (eq frame (selected-frame)))
(get-lru-window frame)))))
Committed in emacs-26
--
-- Stephe
next prev parent reply other threads:[~2018-12-23 18:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-28 18:37 display-buffer-use-some-frame martin rudalics
2018-12-11 19:31 ` display-buffer-use-some-frame Stephen Leake
2018-12-12 8:31 ` display-buffer-use-some-frame martin rudalics
2018-12-23 18:23 ` Stephen Leake [this message]
2018-12-23 19:07 ` display-buffer-use-some-frame martin rudalics
2018-12-23 22:19 ` display-buffer-use-some-frame Stefan Monnier
2018-12-24 8:13 ` display-buffer-use-some-frame martin rudalics
2018-12-24 13:53 ` display-buffer-use-some-frame Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o99c2jb9.fsf@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.