From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Thu, 15 Dec 2022 09:24:51 +0200 Organization: LINKOV.NET Message-ID: <86o7s5i1ec.fsf@mail.linkov.net> References: <8735budxiz.fsf@gmail.com> <87k04li5nw.fsf@gmail.com> <864jvphx4r.fsf@mail.linkov.net> <86tu3mftm0.fsf@mail.linkov.net> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> <86cz8or02n.fsf@mail.linkov.net> <87sfhko3tf.fsf@gmail.com> <868rjbusog.fsf@mail.linkov.net> <87h6xylyox.fsf@gmail.com> <1d03758e-369a-c522-a91a-696243f1074f@yandex.ru> <87cz8ln5lt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19502"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Augusto Stoffel , 58447@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 15 08:32:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5ijQ-0004uE-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Dec 2022 08:32:40 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5ij8-0002uq-Iy; Thu, 15 Dec 2022 02:32:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5iiq-0002rT-Ng for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 02:32:17 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5iio-0001FR-2s for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 02:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5iin-0007hC-IK for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 02:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2022 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.167108947429559 (code B ref 58447); Thu, 15 Dec 2022 07:32:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 15 Dec 2022 07:31:14 +0000 Original-Received: from localhost ([127.0.0.1]:42442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ii2-0007gh-Av for submit@debbugs.gnu.org; Thu, 15 Dec 2022 02:31:14 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:42979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5ihx-0007gH-Tu for 58447@debbugs.gnu.org; Thu, 15 Dec 2022 02:31:10 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 76E3F6000A; Thu, 15 Dec 2022 07:30:58 +0000 (UTC) In-Reply-To: (Dmitry Gutov's message of "Thu, 15 Dec 2022 01:04:12 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251026 Archived-At: > The patches could be combined, but v1 seems to be too invasive for > emacs-29, yet v2 could be just small enough to be considered "bugfix-only". > > So, what does everyone think about the latter? > > If people agree that the v2 patch is an improvement, we can check it in and > leave project-local histories until later. Does the second patch allow such workflows as re-visiting the same relative filenames in another directory? IMHO, the safest fix for emacs-29 would be to add relative filenames to the separate history. If someone might want to use 'file-name-history', then a new variable could be added like 'query-replace-from-history-variable'. Then this variable could be customized to 'file-name-history', or nil. It's needed only when 'project-read-file-name-function' is 'project--read-file-cpd-relative'. But please also note that its value 'project--read-file-absolute' is also broken. It asks confirmation for re-visiting even absolute filenames, because currently 'C-x p f' adds abbreviated filenames, but confirmation checks for absolute.