From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#58447: [PATCH] In project-find-file, add absolute file name to history Date: Sun, 18 Dec 2022 10:36:48 +0200 Organization: LINKOV.NET Message-ID: <86o7s1aykn.fsf@mail.linkov.net> References: <8735budxiz.fsf@gmail.com> <875yg0to11.fsf@gmail.com> <86zgdalj0h.fsf@mail.linkov.net> <86fsdpjasd.fsf@mail.linkov.net> <86k02zjiwj.fsf@mail.linkov.net> <864ju1lt5k.fsf@mail.linkov.net> <403e8284-e32c-f547-748e-371d26eedace@yandex.ru> <86cz8or02n.fsf@mail.linkov.net> <87sfhko3tf.fsf@gmail.com> <868rjbusog.fsf@mail.linkov.net> <87h6xylyox.fsf@gmail.com> <1d03758e-369a-c522-a91a-696243f1074f@yandex.ru> <87cz8ln5lt.fsf@gmail.com> <87359hlycd.fsf@gmail.com> <86r0x0acnh.fsf@mail.linkov.net> <4734c1c2-4bc3-42eb-a919-0e3f1e62fb47@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14779"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Augusto Stoffel , 58447@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 18 10:12:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6piX-0003h7-PO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Dec 2022 10:12:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6piH-0005kk-0M; Sun, 18 Dec 2022 04:12:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6piE-0005jC-LF for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 04:12:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6piE-0001tK-Ci for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 04:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6piD-0003of-Tz for bug-gnu-emacs@gnu.org; Sun, 18 Dec 2022 04:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Dec 2022 09:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58447 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58447-submit@debbugs.gnu.org id=B58447.167135471814651 (code B ref 58447); Sun, 18 Dec 2022 09:12:01 +0000 Original-Received: (at 58447) by debbugs.gnu.org; 18 Dec 2022 09:11:58 +0000 Original-Received: from localhost ([127.0.0.1]:32797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6pi9-0003oF-R1 for submit@debbugs.gnu.org; Sun, 18 Dec 2022 04:11:58 -0500 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:43549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6pi8-0003o6-CD for 58447@debbugs.gnu.org; Sun, 18 Dec 2022 04:11:56 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 8AC7940002; Sun, 18 Dec 2022 09:11:48 +0000 (UTC) In-Reply-To: <4734c1c2-4bc3-42eb-a919-0e3f1e62fb47@yandex.ru> (Dmitry Gutov's message of "Fri, 16 Dec 2022 00:50:58 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251341 Archived-At: >> I agree with Augusto that filtering that implements project-local history >> should be the default behavior for emacs-29. I tried your second patch >> and it nicely handles even such sequences as `C-x p f' and `C-x p F'. >> (and in the opposite direction from `C-x p F' to `C-x p f' it >> filters out external files, that is expected and consistent.) > > That sounds like a consensus, then. I've pushed the v2 patch to emacs-29. Thanks. One very minor detail: when the history contains the project root directory then it's confusing to see that M-p does nothing. It looks like it has no effect because it inserts an empty string. Maybe better to filter out empty strings?