From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Moreton Newsgroups: gmane.emacs.bugs Subject: bug#60562: [PATCH] Fix split-string error if there is a space in the filename. Date: Sun, 15 Jan 2023 12:33:49 +0000 Message-ID: <86o7r0f042.fsf@gmail.com> References: <87zgawgfic.fsf@gmail.com> <83wn5ysjrb.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2.50 (windows-nt) To: 60562@debbugs.gnu.org Cancel-Lock: sha1:Q9sYxaY0nJ4IZMIKhFS49ntFhnA= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 15 13:35:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pH2EK-0000wQ-7v for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 15 Jan 2023 13:35:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pH2EC-0002OU-75; Sun, 15 Jan 2023 07:35:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH2E2-0002Nz-RG for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 07:35:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pH2E2-0005r3-GB for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 07:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pH2E2-0004xp-Bv for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 07:35:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Andy Moreton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Jan 2023 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60562 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.167378604819011 (code B ref -1); Sun, 15 Jan 2023 12:35:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Jan 2023 12:34:08 +0000 Original-Received: from localhost ([127.0.0.1]:56361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH2DA-0004wY-Eq for submit@debbugs.gnu.org; Sun, 15 Jan 2023 07:34:08 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:42998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pH2D7-0004wO-57 for submit@debbugs.gnu.org; Sun, 15 Jan 2023 07:34:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH2D6-00029N-JT for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 07:34:04 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pH2D5-0005iP-9P for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 07:34:04 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pH2D1-0009eo-RN for bug-gnu-emacs@gnu.org; Sun, 15 Jan 2023 13:33:59 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: 3 X-Spam_score: 0.3 X-Spam_bar: / X-Spam_report: (0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NML_ADSP_CUSTOM_MED=0.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253426 Archived-At: On Sat 07 Jan 2023, Eli Zaretskii wrote: >> Cc: 60562@debbugs.gnu.org >> Date: Sat, 7 Jan 2023 17:42:35 +0800 >> From: lux >> >> On Fri, 06 Jan 2023 10:48:43 +0100 >> Robert Pluim wrote: >> >> > You can avoid the issue (and improve portability) by using >> > `directory-files-recursively' instead of `find' >> >> But `hfy-find-cmd' is a configurable variable: >> >> (defcustom hfy-find-cmd >> "find . -type f \\! -name \\*~ \\! -name \\*.flc \\! -path >> \\*/CVS/\\*" "Find command used to harvest a list of files to attempt >> to fontify." :tag "find-command" >> :type '(string)) > > We can convert that to a customizable regexp, and maybe to a predicate > function if a simple regexp won't do. > >> I don't know if using `directory-files-recursively' has other effects. > > Why would that bother us? This is used to find the files under a > given directory, avoiding some files which we know will not be wanted. The fixes for this problem now cause bootstrap to fail, due to the defcustom for hfy-exclude-file-rules containing a version tag that is not a string. AndyM