From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18132@debbugs.gnu.org
Subject: bug#18132: Time for a smarter dired-guess-shell-alist-default? (dired-x.el)
Date: Sat, 02 Dec 2023 19:44:38 +0200 [thread overview]
Message-ID: <86o7f8ijnd.fsf@mail.linkov.net> (raw)
In-Reply-To: <83leag7loj.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Nov 2023 15:07:08 +0200")
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
>> Usually context menus on file managers include two items:
>>
>> "Open" that opens immediately
>> "Open With" with a list of commands
>>
>> So "start" will be used for "Open With" if someone prefers this.
>> Then a new command 'dired-do-open' bound to the "Open" menu item
>> will hard-code 'w32-shell-execute' call with the "open" command.
>
> SGTM, thanks.
Here is this new command 'dired-do-open':
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: dired-do-open.patch --]
[-- Type: text/x-diff, Size: 2515 bytes --]
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 1a17ed749e8..7887cc358aa 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -1401,6 +1401,32 @@ shell-command-guess-open
"Populate COMMANDS by the `open' command."
(append (ensure-list shell-command-guess-open) commands))
+(declare-function w32-shell-execute "w32fns.c")
+
+(defun dired-do-open (&optional arg)
+ "Open the marked files or at click/point externally."
+ (interactive "P" dired-mode)
+ (let ((files (if arg
+ (dired-get-marked-files nil arg)
+ (save-excursion
+ (mouse-set-point last-nonmenu-event)
+ (list (dired-get-filename nil t)))))
+ (command shell-command-guess-open))
+ (when command
+ (cond
+ ((memq system-type '(gnu/linux))
+ (apply #'call-process command nil 0 nil files))
+ ((memq system-type '(ms-dos))
+ (shell-command (concat command " " (mapconcat #'shell-quote-argument files " "))))
+ ((memq system-type '(windows-nt))
+ (w32-shell-execute (or (and (eq command "start") "open") command) (mapconcat #'convert-standard-filename files " ")))
+ ((memq system-type '(cygwin))
+ (apply #'call-process command nil nil nil files))
+ ((memq system-type '(darwin))
+ (apply #'start-process (concat command " " files) nil command files))
+ (t
+ (error "Open not supported on this system"))))))
+
\f
;;; Commands that delete or redisplay part of the dired buffer
diff --git a/lisp/dired.el b/lisp/dired.el
index 97645c731c8..7f4b96353ee 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -2591,6 +2591,9 @@ dired-mode-operate-menu
["Delete Image Tag..." image-dired-delete-tag
:help "Delete image tag from current or marked files"]))
+(declare-function shell-command-guess "dired-aux" (files))
+(defvar shell-command-guess-open)
+
(defun dired-context-menu (menu click)
"Populate MENU with Dired mode commands at CLICK."
(when (mouse-posn-property (event-start click) 'dired-filename)
@@ -2606,6 +2609,9 @@ dired-context-menu
:help "Edit file at mouse click"]
["Find in Other Window" dired-mouse-find-file-other-window
:help "Edit file at mouse click in other window"]
+ ,@(when shell-command-guess-open
+ '(["Open" dired-do-open
+ :help "Open externally"]))
,@(when commands
(list (cons "Open With"
(append
next prev parent reply other threads:[~2023-12-02 17:44 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-28 18:26 bug#18132: Time for a smarter dired-guess-shell-alist-default? (dired-x.el) Reuben Thomas
2014-07-28 18:44 ` bug#18132: Sample code Reuben Thomas
2014-07-29 23:49 ` bug#18132: Time for a smarter dired-guess-shell-alist-default? (dired-x.el) Juri Linkov
2014-07-30 9:12 ` Reuben Thomas
2014-07-30 16:32 ` Juri Linkov
2014-07-30 16:44 ` Reuben Thomas
2014-08-04 23:45 ` Juri Linkov
2014-08-05 9:41 ` Reuben Thomas
2021-10-23 5:25 ` Stefan Kangas
2021-10-23 7:44 ` Eli Zaretskii
2021-10-23 8:16 ` Stefan Kangas
2021-10-23 8:34 ` Eli Zaretskii
2021-10-23 9:48 ` Stefan Kangas
2021-10-23 11:48 ` Eli Zaretskii
2021-10-23 13:06 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 13:20 ` Eli Zaretskii
2021-10-23 13:01 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 13:56 ` Stefan Kangas
2021-10-23 14:03 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 15:45 ` Stefan Kangas
2021-10-23 17:17 ` Gregory Heytings
2021-10-23 20:53 ` Reuben Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-24 6:02 ` Eli Zaretskii
2021-10-24 7:56 ` Juri Linkov
2023-11-23 17:49 ` Juri Linkov
2023-11-23 19:40 ` Eli Zaretskii
2023-11-24 7:51 ` Juri Linkov
2023-11-24 14:24 ` Eli Zaretskii
2023-11-25 18:10 ` Juri Linkov
2023-11-26 10:37 ` Eli Zaretskii
2023-11-27 17:32 ` Juri Linkov
2023-11-28 17:05 ` Juri Linkov
2023-11-28 17:35 ` Eli Zaretskii
2023-11-29 7:09 ` Juri Linkov
2023-11-29 13:07 ` Eli Zaretskii
2023-12-02 17:44 ` Juri Linkov [this message]
2023-12-02 18:37 ` Drew Adams
2023-12-03 17:04 ` Juri Linkov
2023-12-03 21:16 ` Drew Adams
2023-12-06 17:28 ` Juri Linkov
2023-12-07 17:33 ` Juri Linkov
2023-12-07 17:48 ` Eli Zaretskii
2023-12-08 7:37 ` Juri Linkov
2023-12-08 8:08 ` Eli Zaretskii
2023-12-09 17:13 ` Juri Linkov
2024-05-22 6:16 ` Juri Linkov
2024-05-22 12:42 ` Eli Zaretskii
2024-05-23 6:19 ` Juri Linkov
2024-05-23 7:16 ` Eli Zaretskii
2024-05-23 17:31 ` Juri Linkov
2024-05-23 18:15 ` Eli Zaretskii
2024-05-24 6:44 ` Juri Linkov
2024-05-24 7:31 ` Eli Zaretskii
2024-05-24 17:56 ` Juri Linkov
2021-10-23 17:57 ` Howard Melman
2021-10-23 18:29 ` Juri Linkov
2021-10-23 19:22 ` bug#18132: [External] : " Drew Adams
2021-10-24 16:35 ` Howard Melman
2021-10-24 19:08 ` Juri Linkov
2021-10-24 5:10 ` Thierry Volpiatto
2014-07-30 3:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o7f8ijnd.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=18132@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.