From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67527: 30.0.50; FR: Add an option to disable ispell completion in text-mode Date: Sat, 27 Jan 2024 11:56:24 +0200 Message-ID: <86o7d785h3.fsf@gnu.org> References: <83jzoipr5v.fsf@gnu.org> <83ttniiqy3.fsf@gnu.org> <83le8ktl9j.fsf@gnu.org> <87jzo4ficn.fsf@daniel-mendler.de> <837ck4ti1m.fsf@gnu.org> <87h6j8fg50.fsf@daniel-mendler.de> <834jf8tgri.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13766"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, aqua0210@foxmail.com, 67527-done@debbugs.gnu.org, simon@ecksd.com To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 27 10:57:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTfQy-0003MV-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Jan 2024 10:57:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTfQm-0006YZ-AU; Sat, 27 Jan 2024 04:56:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTfQl-0006Y6-8u for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 04:56:55 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTfQl-0008EU-06 for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 04:56:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTfQr-0007UM-UQ for bug-gnu-emacs@gnu.org; Sat, 27 Jan 2024 04:57:01 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jan 2024 09:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 67527 X-GNU-PR-Package: emacs Mail-Followup-To: 67527@debbugs.gnu.org, eliz@gnu.org, aqua0210@foxmail.com Original-Received: via spool by 67527-done@debbugs.gnu.org id=D67527.170634940528755 (code D ref 67527); Sat, 27 Jan 2024 09:57:01 +0000 Original-Received: (at 67527-done) by debbugs.gnu.org; 27 Jan 2024 09:56:45 +0000 Original-Received: from localhost ([127.0.0.1]:53502 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTfQa-0007Tj-HU for submit@debbugs.gnu.org; Sat, 27 Jan 2024 04:56:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33270) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTfQY-0007TV-DH for 67527-done@debbugs.gnu.org; Sat, 27 Jan 2024 04:56:43 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTfQI-0008CW-8i; Sat, 27 Jan 2024 04:56:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9/UUm1oajT83dMJxW1FTWoUe29Z/6+7SJv2uZ5DJhk0=; b=Ra8SqrWjB+W5 VfBtcq7qlTRSWH2KPg6UDmxgjQS41rpNDv/LbJAu3Z7mtHqSge9WzHo0vSQ6RNerpvYKux3TJDEmL v+0SEOByDsWaWfkOsKYcy1bl/83bQ28DJQzW+oUcTU/c/K1njLIxEq97j2aaEABv9eQlr2yLwjsNG /ar4C2sW3PwaGe7dnT8C/vglHR5UOwR9aXIPRaMMeHQPXkE99Uz2PzUaveUqFpDSoq38dS40fxAUm qdamJ/fZdrin2L8S13YNPm3Ky1MWEUNDNPyQFlHY75DxOWtEW4zXK3f//4HBaF2703Ln07G6rUoUK 4Sv3gUJuPw8y7jmUmABaoQ==; In-Reply-To: (message from Eshel Yaron on Sat, 20 Jan 2024 12:33:25 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278984 Archived-At: > From: Eshel Yaron > Cc: Daniel Mendler , aqua0210@foxmail.com, > 67527@debbugs.gnu.org, simon@ecksd.com > Date: Sat, 20 Jan 2024 12:33:25 +0100 > > Eli Zaretskii writes: > > >> From: Daniel Mendler > >> > >> Eli Zaretskii writes: > >> > >> >> From: Daniel Mendler > >> >> > >> >> Eli Zaretskii writes: > >> >> > >> >> > Eshel, given this feedback, I think it would make sense to add a new > >> >> > defcustom that would make text-mode avoid adding > >> >> > ispell-completion-at-point to completion-at-point-functions. Would > >> >> > you please submit such a change and the documentation changes to go > >> >> > with it? TIA. > >> >> > >> >> Maybe the existing defcustom `text-mode-meta-tab-ispell-complete-word' > >> >> could be renamed and reused, taking three values? This way we avoid > >> >> introducing multiple defcustoms for tweaking the same feature. > >> >> > >> >> - `command': Bind `ispell-complete-word' to TAB. > >> >> - `capf': Add `ispell-completion-at-point' to the > >> >> `completion-at-point-functions'. > >> >> - `nil': None of the above. > >> > > >> > Reused, yes. Renamed, I'd rather prefer we avoided that, as it causes > >> > compatibility problems. If we can extend its list of valid values to > >> > support this aspect as well, it would be good. > >> > >> Iiuc the variable was introduced a short while ago on Emacs master, so > >> renaming it may still be possible? > > > > Oh, I think I confused it with another option. Yes, if it was > > introduced recently on master, we can rename it. > > SGTM, see attached patch below. Thanks, installed on master, and closing the bug.